After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 521009 - Theme previews not working
Theme previews not working
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: [obsolete] Appearance
2.21.x
Other Linux
: Normal normal
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2008-03-07 16:01 UTC by Michael Monreal
Modified: 2008-03-11 17:44 UTC
See Also:
GNOME target: ---
GNOME version: 2.21/2.22


Attachments
Screenshot (134.74 KB, image/png)
2008-03-07 16:08 UTC, Michael Monreal
Details

Description Michael Monreal 2008-03-07 16:01:00 UTC
Theme previews seem to be not working in appearance capplet trunk.
Comment 1 Michael Monreal 2008-03-07 16:08:08 UTC
Created attachment 106791 [details]
Screenshot
Comment 2 Jens Granseuer 2008-03-07 17:11:53 UTC
The most likely reason is you've got a broken theme installed. That kind of error now simply makes the thumbnailer exit instead of running into an infinite loop. Works for me.
Comment 3 Michael Monreal 2008-03-07 17:31:00 UTC
Actually you are right... after removing the Darkgilouche theme everything is working again. I guess this will bite many users, though...
Comment 4 Jens Granseuer 2008-03-08 14:27:34 UTC
In this case, the problem appears to be that the metacity theme that the metatheme requires is not installed. Therefore, the theme thumbnail cannot be created. However, we should simply skip that theme and still generate thumbnails for all the others. Going to fix this after the end of the code freeze on Monday.
Comment 5 Jens Granseuer 2008-03-11 17:44:28 UTC
2008-03-11  Jens Granseuer  <jensgr@gmx.net>

        Encountering a theme that could not be thumbnailed (e.g. because the
        metacity theme for a metatheme isn't installed) would make the
        thumbnailer crash. Since it's not restarted by the appearance capplet
        this would result in all themes encountered after the broken one not
        to be thumbnailed either. This change fixes up error handling in the
        thumbnailer so that the broken theme is simply skipped and processing
        can continue with the next one. (bug #521009)

        * theme-thumbnail.c: (create_meta_theme_pixbuf),
        (create_metacity_theme_pixbuf), (message_from_capplet),
        (message_from_child), (read_pixbuf),
        (generate_theme_thumbnail_async), (theme_thumbnail_factory_init):
        properly handle failed thumbnailing attempts