After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 520994 - 4 of 7 tests failed (1.8.1)
4 of 7 tests failed (1.8.1)
Status: RESOLVED FIXED
Product: Gnumeric
Classification: Applications
Component: Main System
1.8.x
Other Linux
: Normal normal
: ---
Assigned To: Jody Goldberg
Jody Goldberg
Depends on:
Blocks:
 
 
Reported: 2008-03-07 14:20 UTC by Ken Moffat
Modified: 2008-07-11 10:42 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Ken Moffat 2008-03-07 14:20:00 UTC
OK, I've no idea if this is a bug, but two of these appear to be caused by missing csv files (the myriad tests on excel files are skipped because the files are missing).  For the other two, I've no idea how to get diagnostic output.

The relevant parts of the output are:
-------------------------------------------------------------------------------
t1901-regress.pl: Check that regress.gnumeric evaluates correctly.
| 
| Gtk-CRITICAL **: gtk_recent_manager_get_for_screen: assertion `GDK_IS_SCREEN (screen)' failed
| aborting...
Cannot open regress.csv: No such file or directory
FAIL: t1901-regress.pl
-------------------------------------------------------------------------------
t7000-goal-seek.pl: Check that goal seeking works right.
| 
| Gtk-CRITICAL **: gtk_recent_manager_get_for_screen: assertion `GDK_IS_SCREEN (screen)' failed
| aborting...
Cannot open goal-seek.csv: No such file or directory
FAIL: t7000-goal-seek.pl
-------------------------------------------------------------------------------
t8100-null-false.pl: Check that code does not mix NULL and FALSE.
Failed command: cd .. && /usr/bin/perl tools/check-null-false-returns
FAIL: t8100-null-false.pl
-------------------------------------------------------------------------------
t8101-gfree.pl: Check that code uses g_free and g_strdup right.
Failed command: cd .. && /usr/bin/perl tools/check-gfrees
FAIL: t8101-gfree.pl
-------------------------------------------------------------------------------
=========================================================================
4 of 7 tests failed
(25 tests were not run)
Please report to http://bugzilla.gnome.org/enter_bug.cgi?product=gnumeric
=========================================================================

 Build was on x86, linux-2.6.24.2, glibc-2.5.1, gcc-4.1.2, binutils-2.17.
Comment 1 Morten Welinder 2008-03-08 01:52:23 UTC
> Gtk-CRITICAL **: gtk_recent_manager_get_for_screen: assertion `GDK_IS_SCREEN
(screen)' failed

This is the reason the csv files are not created.  I am not quite sure why
you see this error, though.  What version of gtk+ are you using?

For the former two, can you please try:

cd top-level-gnumeric-directory
/usr/bin/perl tools/check-null-false-returns
/usr/bin/perl tools/check-gfrees

and see what it complains over?
Comment 2 Ken Moffat 2008-03-11 00:14:10 UTC
gtk+-2.10.13

 I don't have either of the scripts - not in tools/, not anywhere else.  That is obviously why the tests fail.  Can't see any reference to them apart from the attempt to run them.  This is after a fresh configure, make, make check:

ken@ac30 ~/gnumeric-1.8.1 $ls tools
ChangeLog  gconf-schemas-to-win32-reg.c  Makefile  Makefile.am  Makefile.in  win32
ken@ac30 ~/gnumeric-1.8.1 $

ken@ac30 ~/gnumeric-1.8.1 $find | xargs grep check-gfrees
./tools/ChangeLog:	* check-gfrees: Check g_list_free, g_slist_free,
./tools/ChangeLog:	* check-gfrees: New checker.
./test/t8101-gfree.pl:&test_command ("cd $topsrc && $PERL tools/check-gfrees", sub { /^$/ });

ken@ac30 ~/gnumeric-1.8.1 $find | xargs grep check-null-false
./tools/ChangeLog:	* check-null-false-returns: New program.
./test/t8100-null-false.pl:&test_command ("cd $topsrc && $PERL tools/check-null-false-returns",


Comment 3 Morten Welinder 2008-03-11 19:37:43 UTC
Ah, we don't put those in the tar ball.  That's easy to fix.

Now with respect to

| Gtk-CRITICAL **: gtk_recent_manager_get_for_screen: assertion `GDK_IS_SCREEN (screen)' failed

What gtk+ version are you using?
Comment 4 Ken Moffat 2008-03-12 10:27:55 UTC
As I said in the first line of my previous reply (2.10.13).
Comment 5 Morten Welinder 2008-03-13 02:32:09 UTC
Clearly I am blind, :-/

The two script problems have been fixed.
Comment 6 Jody Goldberg 2008-07-11 10:42:28 UTC
The only tests I see failing in current 1.8.x are valgrind related due to leaks in cairo.