After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 520888 - udpsrc has some issues on Windows
udpsrc has some issues on Windows
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other All
: Normal critical
: 0.10.8
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2008-03-07 00:58 UTC by Ole André Vadla Ravnås
Modified: 2008-03-07 10:01 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
udpsrc_make_gst_poll_controllable_on_win32 (630 bytes, patch)
2008-03-07 01:01 UTC, Ole André Vadla Ravnås 		committed Details | Review
udpsrc_win32_teardown_fix (532 bytes, patch)
2008-03-07 01:01 UTC, Ole André Vadla Ravnås 		committed Details | Review

Description Ole André Vadla Ravnås 2008-03-07 00:58:43 UTC 
Please describe the problem:
After the move to GstPoll it seems that controllable is set to FALSE on Windows, which makes shutdown deadlock. This works fine with this set to TRUE (like on non-Windows) with the latest patch from #520671 (which makes GstPoll work on Windows).

Another slightly smaller issue is that WSACleanup is not called properly balanced with WSAStartup.

Steps to reproduce:


Actual results:


Expected results:


Does this happen every time?


Other information:
Comment 1 Ole André Vadla Ravnås 2008-03-07 01:01:14 UTC 
Created attachment 106737 [details] [review]
udpsrc_make_gst_poll_controllable_on_win32

Fix for the first issue.
Comment 2 Ole André Vadla Ravnås 2008-03-07 01:01:58 UTC 
Created attachment 106738 [details] [review]
udpsrc_win32_teardown_fix

Fix for the second and final issue.
Comment 3 Wim Taymans 2008-03-07 10:01:53 UTC 
        Patch by: Ole André Vadla Ravnås  <ole.andre.ravnas@tandberg.com>

        * gst/udp/gstudpsrc.c: (gst_udpsrc_finalize), (gst_udpsrc_start),
        (gst_udpsrc_stop):
        Properly balance WSA_Cleanup with WSA_Startup.
        Also make the poll controllable on windows. Fixes #520888.