After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 520764 - double buffer unref in speexenc error handling
double buffer unref in speexenc error handling
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other Linux
: Normal critical
: 0.10.8
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2008-03-06 15:05 UTC by Olivier Crête
Modified: 2008-03-07 12:40 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
unref the buffer only once (579 bytes, patch)
2008-03-06 15:05 UTC, Olivier Crête
committed Details | Review

Description Olivier Crête 2008-03-06 15:05:22 UTC
If there is a not-negotiated error in speexenc, the buffer is unref'd twice
Comment 1 Olivier Crête 2008-03-06 15:05:59 UTC
Created attachment 106688 [details] [review]
unref the buffer only once
Comment 2 Sebastian Dröge (slomo) 2008-03-07 12:40:06 UTC
2008-03-07  Sebastian Dröge  <slomo@circular-chaos.org>

	Patch by: Olivier Crete <tester at tester dot ca>

	* ext/speex/gstspeexenc.c: (gst_speex_enc_chain):
	Unref the buffers only once when handling not-negotiated errors.
	Fixes bug #520764.