GNOME Bugzilla – Bug 520653
pitivi.desktop fixes and more
Last modified: 2009-09-06 07:20:08 UTC
I set about to update pitivi.desktop and got a little carried away. Possibly these several issues should be in different patches, but they're all small fixes. #1: Updated the Categories line. I removed the deprecated Application, added AudioVideoEditor, and got rid of the distro-specific entries, figuring that was best done by the packagers (and since it seemed like that part of the file hadn't been looked over in a long time). #2: Made the Name and Comment lines translatable. This requires an extra level of indirection for the desktop file, so desktop.in becomes desktop.in.in. Also, after adding the lines to Makefile.am to support this, autogen.sh started giving errors until I did a fresh intltoolize from my 0.37.1 version. I also changed the text of the Comment line. Modify as you see fit, but the HIG does recommend the "Do X" format. #3: Made the Icon line not include the ".png". Along with this change, I set up pitivi to install its application icon in the right place so that it is themeable and future icons of differing sizes are easier to install. This also required modifying the source to use icon theme calls for the app icon.
Created attachment 106655 [details] [review] Patch
Created attachment 106656 [details] New desktop.in.in file With this, you can svn remove pitivi.desktop.in
Hello, Any news on this patch? Thanks -- This message is brought by the GNOME Bugsquad Team
Hello, The patch is still there. Thanks for giving some feedback to the gentle guy who did the patch. Thanks
argh, too late for this series of release. Marking it as a blocker of 0.13.2
Doesn't seemt to apply correctly against current git head. Michael, any chance you could provide an updated patch ?
Created attachment 138866 [details] [review] Updated patch against git Here's a new git patch that applies cleanly.
Created attachment 138867 [details] [review] Cleanup I also noticed that pitivi got a proper icons directory that installs all sorts of goodies into the hicolor theme (and then doesn't use them without my patch above). So here's an additional patch that deletes the top level png file, moves the icon theme updating code to icons/Makefile.am and updates the spec.in file to install all the hicolor icons.
commit 2f78259624d473e286fd319f43ad060c93dbc0a9 Author: Michael Terry <michael.terry@canonical.com> Date: Mon Jul 20 20:19:42 2009 -0400 Remove duplicate icon file http://bugzilla.gnome.org/show_bug.cgi?id=520653 commit eba58f8abbb61f9bd38eeb3b05adac9c55fe72b9 Author: Michael Terry <michael.terry@canonical.com> Date: Mon Jul 20 20:11:15 2009 -0400 Update desktop file, use icon theme http://bugzilla.gnome.org/show_bug.cgi?id=520653