After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 520629 - deCOMtaminate plugins
deCOMtaminate plugins
Status: RESOLVED FIXED
Product: totem
Classification: Core
Component: Browser plugin (obsolete)
unspecified
Other Linux
: Normal enhancement
: ---
Assigned To: totem-browser-maint
totem-browser-maint
: 541496 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2008-03-05 23:15 UTC by Christian Persch
Modified: 2008-07-04 09:36 UTC
See Also:
GNOME target: ---
GNOME version: 2.23/2.24


Attachments
patch; please review (476.53 KB, patch)
2008-05-29 16:46 UTC, Christian Persch
accepted-commit_now Details | Review

Description Christian Persch 2008-03-05 23:15:21 UTC
In order to make the plugins work with webkit, we need to port the plugin from XPCOM scripting to the new 'NPRuntime' scripting API, and remove all other traces of XPCOM and mozilla strings from it.

I'm working on it, but it's going to be really hairy.
Comment 1 Christian Persch 2008-04-01 17:50:42 UTC
I'm working on this.
Comment 2 Christian Persch 2008-05-29 16:46:55 UTC
Created attachment 111747 [details] [review]
patch; please review

This seems to be about ready to me; needs more testing of course but that's the sort of thing that's better be done distributed, by putting the patch in and fixing regressions :)

(There is one additional 'regression': I didn't port the complex plugin, since it's pretty much useless since there are no gst codecs for the complex formats and rtp doesn't work either.)
Comment 3 Bastien Nocera 2008-05-29 23:26:28 UTC
Please commit, and we'll fix the rest as bugs come in.

A couple of things:
- please keep the idl files at least in the repo, for documentation purposes
- don't add the .gitignore files to the repo
- the complex plugin actually works with xine-lib, and a bunch of real audio shared-libs.
Comment 4 Christian Persch 2008-05-30 10:59:22 UTC
(In reply to comment #3)
> Please commit, and we'll fix the rest as bugs come in.
Ok.

> A couple of things:
> - please keep the idl files at least in the repo, for documentation purposes
Yes, I didn't remove them, just the Makefile.am in idl/.

> - don't add the .gitignore files to the repo
:(

> - the complex plugin actually works with xine-lib, and a bunch of real audio
> shared-libs.

Hmm ok. It will be easy to port... an exercise for an interested reader :)
Comment 5 Bastien Nocera 2008-05-30 11:07:01 UTC
(In reply to comment #4)
> (In reply to comment #3)
> > - don't add the .gitignore files to the repo
> :(

I guess you can add them if you care about them so much ;)
Comment 6 Christian Persch 2008-05-30 17:35:30 UTC
Thanks! It's easier if it's in svn since then I don't have to re-add it on every git branch...

Committed to svn. Please open new bug(s) for any regressions found.
Comment 7 Bastien Nocera 2008-07-04 09:36:22 UTC
*** Bug 541496 has been marked as a duplicate of this bug. ***