After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 520342 - Import stop button icon
Import stop button icon
Status: RESOLVED FIXED
Product: banshee
Classification: Other
Component: User Interface
git master
Other Linux
: Normal minor
: 0.98.1
Assigned To: Banshee Maintainers
Banshee Maintainers
Depends on:
Blocks:
 
 
Reported: 2008-03-04 18:17 UTC by Michael Monreal
Modified: 2008-03-11 00:31 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Screenshot (26.60 KB, image/png)
2008-03-04 18:18 UTC, Michael Monreal 		  Details
Proposed solution (722 bytes, patch)
2008-03-06 11:01 UTC, Lukas Lipka 		committed Details | Review

Description Michael Monreal 2008-03-04 18:17:08 UTC 
The "Importing" notification "dialog" (bottom of sources list) uses the window-close icon. The correct icon would be process-stop, as used in the confirmation dialog. The close icon suggests the import will go on silently in the background if pressed.

Also, the dialog uses dialog-question. I think the HIG¹ says to use the dialog-warning icon?

[1] http://developer.gnome.org/projects/gup/hig/draft_hig_new/windows-alert.html
Comment 1 Michael Monreal 2008-03-04 18:18:32 UTC 
Created attachment 106567 [details]
Screenshot
Comment 2 Gabriel Burt 2008-03-04 18:24:48 UTC 
Agreed on the stop button.  I don't think we should change the dialog's icon though, because the warning is used for (according to the HIG) when the action may cause data loss - which stopping importing doesn't.
Comment 3 Andrew Conkling 2008-03-04 20:02:19 UTC 
I may be able to work up a quick patch for this.
Comment 4 Michael Monreal 2008-03-05 12:15:44 UTC 
(In reply to comment #3)
> I may be able to work up a quick patch for this.
> 

Did you get it? I thought the same but I can't find where the definition is in the code... searched for gtk-close, window-close and Gtk.Stock.Close...
Comment 5 Lukas Lipka 2008-03-06 11:01:54 UTC 
Created attachment 106671 [details] [review]
Proposed solution
Comment 6 Michael Monreal 2008-03-06 11:08:17 UTC 
Heh... that's the right fix indeed ;)
Comment 7 Andrew Conkling 2008-03-06 12:54:55 UTC 
(In reply to comment #5)
> Created an attachment (id=106671) [edit]
> Proposed solution

Thanks for your patch; I'll try to get it committed quickly.
Comment 8 Aaron Bockover 2008-03-11 00:31:09 UTC 
Patch committed, thanks all!