GNOME Bugzilla – Bug 520114
Seahorse icon makeover
Last modified: 2008-08-31 19:52:28 UTC
Seahorse currently has a few problems related to icons: - some icons are not available in all required sizes, leading to ugly scaling - some icons look a bit blurry (missing grid alignment?) - some icons could use better metaphors - some items/buttons use GTK stock icons for actions that require other icons - some icons don't really have any meaning - the icons are installed in a legacy location To solve this, we need to patch seahorse to make use of proper icon theming and provide all the following icons (hope I got this list right): Application icons: seahorse (16, 22, 24, 32, 48) // already done by Lapo seahorse-preferences (16, 22, 24, 32, 48) // desktop key related settings seahorse-applet (16, 22, 24, 32, 48) Icons needing refresh for main interface: seahorse-key-personal (22, 48) // gpg key seahorse-key-ssh (22, 48) // ssh key seahorse-sign (48) seahorse-sign-ok (48) // signed & signature verified seahorse-sign-bad (48) // signed & verification failed seahorse-sign-unknown (48) // signed & no key to verify New icons needed for main interface: seahorse-person (64) // placeholder for real photo, perhaps use stock_person? sync (16, 22) => get this one into gnome-icon-theme? many apps want this sign (16, 22) => "sign a key" action revoke (16, 22) => revoke a signature Icons needing refresh for applet: seahorse-applet-unknown (22) => clipboard (empty?) seahorse-applet-text (22) => clipboard has text seahorse-applet-encrypted (22) => clipboard has encrypted text seahorse-applet-signed (22) => clipboard has signed text seahorse-applet-key (22) => clipboard has a key Icons we can most likely cut: seahorse-key seahorse-person (22, 48) seahorse-share-keys Let's make sure we finish all the required work to push this into 2.23.x early after the branching.
Created attachment 106481 [details] [review] Patch v0.1 This is probably as good as I can make it without spending much more time with the seahorse code. As far as I can see there are two issues here: - "(seahorse:31233): Gtk-WARNING **: could not load image: Icon 'gnome-stock-authentication' not present in theme" -> I'm not sure what happens here or where the icons in the gnome keyring list come from. Probably some "unported" code in seahorse_key_get_stock_id? - seahorse-preferences (when started standalone) has no window icon and missing sharing icon. As the sharing icon is likely to be removed, only the window icon is a problem. Adam told me that the preferences dialog will probably be split out of the app completely, so that would be easy to solve in that case. If not, we would probably have to make it another icon if started standalone (seahorse.png vs seahorse-preferences.png)
Created attachment 106482 [details] Icons v0.1 This is basicly a repack of all the old icons and Lapo's new app icon and many placeholder icons (most of which we won't need in the end. I will update this pack when the new icons are available. The icons/ folder will go into data/ and replace pixmaps/
The list looks good. The seahorse-applet-unknown is used not when the clipboard is empty, but when it has something that isn't text in it.
Created attachment 106487 [details] [review] Patch v0.1.1 Fixed patch, don't know how I managed to produce the first one...
Created attachment 106528 [details] [review] Patch v1.2 Gets rid of the GNOME_STOCK_AUTHENTICATION missing error message. A replacement for GNOME_STOCK_BLANK is still needed though.
One thing I just noticed is that seahorse-gtkstock.h should better be called something like seahorse-icons.h Adding Lapo to the CC, let's get those icons done!
*** Bug 524081 has been marked as a duplicate of this bug. ***
If you are modifying seahorse-gkeyring-item.c's use of GNOME_STOCK_AUTHENTICATION and replacing it with GTK_STOCK_DIALOG_AUTHENTICATION, you should drop the #define for the GNOME_STOCK_AUTHENTICATION.
So it's late into the cycle again... Do we want to at least fix the main app icon for 2.24? I still really like the icons lapo did...
I'd be ok with fixing the main icon now, as long as we can get the UI Freeze break. This next bit is an honest question because I'm not at all a UI guru: Is it worth fixing one icon at the expense of consistent look and feel?
That's a very valid question, but as seahorse is already shipping "tango icons" (more or less, at least they aim to be) I would not see this as a problem in this case. Anything you don't like about Lapo's initial design or want to be changed? IIRC there's about 10 days left before freeze so we should be able to get this part done.
The design is good by me. The only thing I think that stands out is the difference in color sets between the new main icon and the old icons.
Created attachment 115936 [details] preference icon Regarding the icons in the actual UI, I don't think we need to make sure those are the same colors as the app key, so I think Michaels work is all well.
Created attachment 115946 [details] Seahorse icon stuff for 2.24 So this is what we should do for 2.24 IMHO: * replaces seahorse and seahorse-preferences icons (launcher/window/about) * patches for seahorse and seahorse-plugins * patch includes fix for about menu item * icons dir goes to seahorse/data/ as is (includes makefile & source dir) * removes seahorse and seahorse-preferences icons from pixmaps/ makefiles Question: why does seahorse-plugins also ship icons, even to the same location? I guess this will cause much trouble for packagers. IMHO seahorse-plugins should only ship the icons it really needs, same for seahorse.
Any news here? It's just a few days left till UI freeze.
Sorry, I've been at a conference in Chicago since you sent in the patch. Answer: All part of fixing inconsistencies in the split of seahorse-plugins from seahorse. I believe if you ask Stef, he would say it was expedient. seahorse-plugins 2008-08-13 Adam Schreiber <sadam@clemson.edu> * pixmaps/22x22/Makefile.am: * pixmaps/48x48/Makefile.am: * pixmaps/scalable/Makefile.am: * libseahorse/seahorse-widget.c: * libseahorse/seahorse-gtkstock.c: * libseahorse/seahorse-gtkstock.h: Icon makover. Patch from Michael Monreal. Part of fixing bug #520114 seahorse 2008-08-13 Adam Schreiber <sadam@clemson.edu> * data/icons/hicolor_apps_16x16_seahorse.png (added): * data/icons/hicolor_apps_16x16_seahorse-preferences.png (added): * data/icons/hicolor_apps_22x22_seahorse.png (added): * data/icons/hicolor_apps_22x22_seahorse-preferences.png (added): * data/icons/hicolor_apps_24x24_seahorse.png (added): * data/icons/hicolor_apps_24x24_seahorse-preferences.png (added): * data/icons/hicolor_apps_32x32_seahorse.png (added): * data/icons/hicolor_apps_32x32_seahorse-preferences.png (added): * data/icons/hicolor_apps_48x48_seahorse.png (added): * data/icons/hicolor_apps_48x48_seahorse-preferences.png (added): * data/icons/Makefile.am (added): * data/icons/svg (added): * data/icons/svg/seahorse.svg (added): * data/icons/svg/seahorse-preferences.svg (added): * pixmaps/22x22/Makefile.am: * pixmaps/48x48/Makefile.am: * pixmaps/scalable/Makefile.am: * src/seahorse-viewer.vala: * data/Makefile.am: * configure.in: * libseahorse/seahorse-widget.c: * libseahorse/seahorse-gtkstock.c: * libseahorse/seahorse-gtkstock.h: Icon makeover. Patch from Michael Monreal. Fixes bug #520114 We should be good now. Let me know if I accidentily missed something.
BTW guys, these new icons and fixes look really good.