Bug 519791 – 0.23: applet crashes when usb dongle is removed after having browsed a device

After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.

Bug 519791 - 0.23: applet crashes when usb dongle is removed after having browsed a device


Summary:	0.23: applet crashes when usb dongle is removed after having browsed a device


Status:	RESOLVED FIXED

Product:	bluez-gnome
Classification:	Deprecated
Component:	applet
Version:	unspecified
Hardware:	Other Linux

Importance:	Normal normal
Target Milestone:	---
Assigned To:	bluez-gnome-maint@gnome.bugs
QA Contact:	bluez-gnome-maint@gnome.bugs

URL:
Whiteboard:

Depends on:
Blocks:

Reported:	2008-03-01 19:56 UTC by Diego Escalante Urrelo (not reading bugmail)
Modified:	2008-03-12 22:38 UTC

See Also:
GNOME target:	---
GNOME version:	---

Attachments
bluez-gnome-device-removal-crash.patch (831 bytes, patch) 2008-03-10 23:27 UTC, Bastien Nocera	none	Details \| Review
bluez-gnome-device-removal-crash.patch (2.87 KB, patch) 2008-03-11 01:03 UTC, Bastien Nocera	none	Details \| Review
bluez-gnome-device-removal-crash-2.patch (4.25 KB, patch) 2008-03-11 15:45 UTC, Bastien Nocera	committed	Details \| Review

Description Diego Escalante Urrelo (not reading bugmail) 2008-03-01 19:56:41 UTC

Browse a device, remove your usb bt adapter (after no nautilus is open in the location), see a crash, this is printed in the terminal, couldn't get a trace:

(bluetooth-applet:12560): GLib-GObject-WARNING **: invalid uninstantiatable type `(null)' in cast to `BluetoothDeviceSelection'

(bluetooth-applet:12560): GLib-GObject-WARNING **: instance of invalid non-instantiatable type `(null)'

If you can't reproduce I'll try to get the trace.

ii  bluetooth                                  3.26-0ubuntu3 
ii  bluez-audio                                3.26-0ubuntu3  
ii  bluez-gnome                                0.23-0ubuntu1   
ii  bluez-utils                                3.26-0ubuntu3  
ii  libbluetooth-dev                           3.26-0ubuntu1  
ii  libbluetooth2                              3.26-0ubuntu1

Comment 1 Bastien Nocera 2008-03-03 10:53:01 UTC

Works here. Could you please get a backtrace of the warning (run with --g-fatal-warnings)?

Comment 2 Diego Escalante Urrelo (not reading bugmail) 2008-03-09 07:43:04 UTC

(bluetooth-applet:12556): GLib-GObject-WARNING **: invalid unclassed pointer in cast to `BluetoothDeviceSelection'

(bluetooth-applet:12556): GLib-GObject-CRITICAL **: g_type_instance_get_private: assertion `instance != NULL && instance->g_class != NULL' failed

Program received signal SIGSEGV, Segmentation fault.
[Switching to Thread 0xb7315720 (LWP 12556)]
0x08054502 in default_adapter_changed (gobject=0x8139140, arg1=0x810e6b8, 
    data=0x81288a8) at bluetooth-device-selection.c:328
328			gtk_widget_set_sensitive (GTK_WIDGET (priv->treeview), FALSE);
(gdb) thread apply all bt

+ Trace 191837

Thread 1 (Thread 0xb7315720 (LWP 12556))

#0 default_adapter_changed
at bluetooth-device-selection.c line 328
#1 g_cclosure_marshal_VOID__PARAM
from /usr/lib/libgobject-2.0.so.0
#2 g_closure_invoke
from /usr/lib/libgobject-2.0.so.0
#3 ??
from /usr/lib/libgobject-2.0.so.0
#4 ??
#5 ??

Comment 3 Bastien Nocera 2008-03-10 23:26:04 UTC

I see what the problem is, we don't clean up the signal handlers when finalizing the object.

Comment 4 Bastien Nocera 2008-03-10 23:27:47 UTC

Created attachment 107025 [details] [review]
bluez-gnome-device-removal-crash.patch

Does this work for you?

Comment 5 Diego Escalante Urrelo (not reading bugmail) 2008-03-11 00:42:43 UTC

Nope, client is not defined.

Comment 6 Bastien Nocera 2008-03-11 00:57:55 UTC

Bleh, that patch is completely wrong.

Comment 7 Bastien Nocera 2008-03-11 01:03:37 UTC

Created attachment 107026 [details] [review]
bluez-gnome-device-removal-crash.patch

Patch that actually compiles.

Comment 8 Diego Escalante Urrelo (not reading bugmail) 2008-03-11 02:00:07 UTC

Uhm, makes no difference.

Comment 9 Bastien Nocera 2008-03-11 15:45:26 UTC

Created attachment 107066 [details] [review]
bluez-gnome-device-removal-crash-2.patch

That actually fixes it for me.

Comment 10 Diego Escalante Urrelo (not reading bugmail) 2008-03-11 16:31:52 UTC

It does here too.

Comment 11 Bastien Nocera 2008-03-11 18:45:00 UTC

Posted the patch to the list.

Comment 12 Bastien Nocera 2008-03-12 22:38:24 UTC

Committed by Marcel.