After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 519548 - Add Hildon support to cheese
Add Hildon support to cheese
Status: RESOLVED FIXED
Product: cheese
Classification: Applications
Component: general
git master
Other Linux
: Normal enhancement
: ---
Assigned To: Cheese Maintainer(s)
Cheese Maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2008-02-29 15:45 UTC by Matthew Garrett
Modified: 2008-03-14 14:23 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Hildon support patch (6.45 KB, patch)
2008-02-29 15:46 UTC, Matthew Garrett 		committed Details | Review

Description Matthew Garrett 2008-02-29 15:45:32 UTC 
The attached patch (against svn) adds hildon support to Cheese. It does some mildly nasty hacking with reparenting of widgets in order to avoid needing to ship (and synchronise) multiple UI files, but other than that the changes are straightforward and fairly clean.
Comment 1 Matthew Garrett 2008-02-29 15:46:12 UTC 
Created attachment 106267 [details] [review]
Hildon support patch
Comment 2 Loïc Minier 2008-02-29 16:02:31 UTC 
(Woohoo!)
Comment 3 Jaap A. Haitsma 2008-02-29 19:21:01 UTC 
Patch seems fine to me.

 
I don't think we need to ask a freeze break for this because it doesn't influence the normal code at all.

Please commit after adding a comment to the reparenting part such that others know you do this to not have two ui files
Comment 4 daniel g. siegel 2008-03-01 23:50:21 UTC 
matthew, thanks for commiting the patch _finally_ ;)
Comment 5 Jaap A. Haitsma 2008-03-02 11:02:21 UTC 
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.

2008-03-02  Jaap Haitsma <jaap@haitsma.org>

        * configure.ac,
          src/cheese-fileutil.c,
          src/cheese-thumb-view.c,
          src/cheese-window.c,
          src/Makefile.am:
          Add a patch of Matthew Garret <mjg59-gnomebugzilla@40srcf.ucam.org>
          to add support for building cheese on the hildon desktop. Fixes
          bug #519548
Comment 6 daniel g. siegel 2008-03-14 01:09:52 UTC 
we did not commit that patch to trunk as we couldnt add any strings. we could do now, jaap?
Comment 7 Jaap A. Haitsma 2008-03-14 13:44:44 UTC 
committed to trunk now
Comment 8 daniel g. siegel 2008-03-14 14:23:45 UTC 
thanks jaap!