After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 519240 - On ffmpeg decoders, caps on srcpad have wrong size if lowres property is used
On ffmpeg decoders, caps on srcpad have wrong size if lowres property is used
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-libav
git master
Other Linux
: Normal normal
: 0.10.4
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2008-02-28 10:11 UTC by Josep Torra Valles
Modified: 2011-05-19 06:58 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Patch to fix the issue (732 bytes, patch)
2008-02-28 10:12 UTC, Josep Torra Valles
needs-work Details | Review

Description Josep Torra Valles 2008-02-28 10:11:36 UTC
I've been playing with the lowres feature that some decoders in ffmpeg provide.

In particular I've been playing with the ffdec_mpeg2video and I noticed that the size specified in the srcpad wasn't downscaled. 

It produces 2/4 copies of the image and sometimes a segfault.

I've been testing it withe the following pipeline:

gst-launch-0.10 -v filesrc location=chickenpayback.mpeg ! flupsdemux ! mpegvideoparse ! ffdec_mpeg2video lowres=1 ! queue ! xvimagesink
Comment 1 Josep Torra Valles 2008-02-28 10:12:51 UTC
Created attachment 106146 [details] [review]
Patch to fix the issue

This is a patch to fix the issue, I couldn't notice any side effect.
Comment 2 Wim Taymans 2008-03-03 12:04:46 UTC
seems to make things crash at the end and the video is corrupted.
Comment 3 Sebastian Dröge (slomo) 2011-05-19 06:58:04 UTC
I think this was fixed as part of this commit, although it's completely unrelated :)

commit 62bc3b929b1ce8d5d3be9442c83b8febef5c8508
Author: Wim Taymans <wim.taymans@gmail.com>
Date:   Wed Mar 5 17:02:33 2008 +0000

    ext/ffmpeg/gstffmpegdec.c: Detect DTS or PTS as timestamps. This is done by 
    
    Original commit message from CVS:
    * ext/ffmpeg/gstffmpegdec.c: (gst_ffmpegdec_class_init),
    (gst_ffmpegdec_setcaps), (check_keyframe),
    (gst_ffmpegdec_video_frame), (gst_ffmpegdec_sink_event),
    (gst_ffmpegdec_set_property):
    Detect DTS or PTS as timestamps. This is done by tracking frame
    reordering on the output and making sure that timestamps don't go
    backwards. Fixes #482660.