After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 519088 - gst_mulawdec_chain() may call gst_util_uint64_scale_int() with denom=0
gst_mulawdec_chain() may call gst_util_uint64_scale_int() with denom=0
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other All
: Normal minor
: 0.10.8
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2008-02-27 16:36 UTC by Peter Kjellerstedt
Modified: 2008-02-28 08:36 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Peter Kjellerstedt 2008-02-27 16:36:02 UTC 
Please describe the problem:
The change in gst-plugins-good/gst/law/mulaw-decode.c:gst_mulawdec_chain() to calculate the duration from the rate and channels causes an assertion in gst_util_uint64_scale_int() if there is no caps with these values set (it will get a denom of 0). I know too little about the linking of a pipeline to tell whether this should have been prevented already at the time the pipeline was linked, or if it is allowed to reach gst_mulawdec_chain() without a caps which does not contains rate or channels.

Steps to reproduce:
gst-launch fakesrc ! mulawdec ! fakesink

Actual results:


Expected results:


Does this happen every time?


Other information:
Comment 1 Sebastian Dröge (slomo) 2008-02-28 08:36:45 UTC 
Hm, in theory this should've been set already as set_caps() should be called before any chain functions. Well, fixed in CVS :)

2008-02-28  Sebastian Dröge  <slomo@circular-chaos.org>

        * gst/law/mulaw-decode.c: (gst_mulawdec_chain):
        Return GST_FLOW_NOT_NEGOTIATED when the caps are not set
        yet on the srcpad. We need rate and channels before we
        can do any processing. Fixes bug #519088.