After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 519001 - [wildmidi] Doesn't handle seeking correctly
[wildmidi] Doesn't handle seeking correctly
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal major
: 0.10.15
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2008-02-27 07:40 UTC by Sebastian Dröge (slomo)
Modified: 2009-09-04 15:35 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Sebastian Dröge (slomo) 2008-02-27 07:40:22 UTC
Hi,
the wildmidi element currently does not handle seeking correctly. First, seeking does not work at all it seems and then the error reporting seems to be a bit too hard:

    libWildMidi(WildMidi_Init:3707): ERROR Library not Initialized
    ** Message: don't know how to handle audio/midi
    ** Message: Error: A audio/midi decoder plugin is required to play
    this stream, but not installed.
    gstdecodebin.c(792): close_pad_link (): /play/decodebin1:
    No decoder to handle media type 'audio/midi'

    ** Message: Missing plugin: gstreamer|0.10|totem|audio/midi
       decoder|decoder-audio/midi (audio/midi decoder)
       ** Message: Automatic missing codec installation not supported (helper
          script missing)


So wildmidi should check for errors while seeking and handle them better (i.e. plya from the current position instead of exploding) and then seeking should made to work somehow ;)
Comment 1 Sebastian Dröge (slomo) 2008-02-27 07:43:03 UTC
Debian bug: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=468083
Comment 2 Wim Taymans 2009-09-04 15:35:30 UTC
Works for me now after some massive cleanups.

commit f874e30998683eed73eea65a657452293595469f
Author: Wim Taymans <wim.taymans@collabora.co.uk>
Date:   Fri Sep 4 17:27:52 2009 +0200

    wildmidi: cleanups and fix seeking
    
    Remove time_per_frame, it's too inaccurate.
    Fix convert for -1 values.
    Use scaling to convert samples to time.
    Fix segment handling.
    Fix seeking.
    Fix buffer clipping (not yet enabled)
    Protect the WildMidi library with the object lock to avoid races when changing
    properties.
    Fix offsets on output buffers, for raw audio the offset contains the sample
    position not byte position.
    Add better DISCONT handling.
    
    Fixes #519001