GNOME Bugzilla – Bug 518933
mp3 tags are not copied when converting to another format
Last modified: 2008-02-27 13:17:50 UTC
The tags from a mp3 file are lost when converting. I tried the following command: gst-launch-0.10 -t filesrc location=test.mp3 ! decodebin ! audioconvert ! vorbisenc ! oggmux ! filesink location=test.mp3.ogg The resulting Ogg Vorbis file doesn't contains tags at all. The source mp3 have id3v2 tags. The -t option does print correct tags. The output format doesn't matter, it's also broken when converting to flac or mp3.
This might be caused by id3demux to output the tags before any NEWSEGMENT event is sent... Tim, what do you think?
No, it isn't. I can reproduce it though, vorbisenc only gets the tags from mp3parse it seems.
Ok, when using ... ! id3demux ! mp3parse ! mad ! audioconvert ! ... it works. Reason is, that decodebin didn't link mp3parse to mad yet, thus the TAG event is dropped: 0:00:01.561236115 10263 0x8173f78 DEBUG GST_PADS gstpad.c:4150:gst_pad_push_event:<mpegaudioparse0:src> Dropping event because pad is not linked
2008-02-27 Sebastian Dröge <slomo@circular-chaos.org> * ext/mad/gstmad.c: (gst_mad_dispose), (gst_mad_sink_event), (gst_mad_chain): * ext/mad/gstmad.h: * gst/mpegaudioparse/gstmpegaudioparse.c: (gst_mp3parse_dispose), (gst_mp3parse_sink_event), (gst_mp3parse_emit_frame): * gst/mpegaudioparse/gstmpegaudioparse.h: Cache all events except EOS if we still have to send a NEWSEGMENT event. This will let TAG events be forwarded until after decodebin to an encoder for example as decodebin only links the pads after NEWSEGMENT. Fixes bug #518933.