After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 518918 - {gnome-sudoku,glchess}/src/Makefile.am, srcdir needs changed to builddir
{gnome-sudoku,glchess}/src/Makefile.am, srcdir needs changed to builddir
Status: RESOLVED FIXED
Product: gnome-games-superseded
Classification: Deprecated
Component: general
2.21.x
Other Mac OS
: Normal blocker
: ---
Assigned To: Jason Clinton
GNOME Games maintainers
Depends on:
Blocks:
 
 
Reported: 2008-02-26 20:47 UTC by paul
Modified: 2008-04-10 04:01 UTC
See Also:
GNOME target: ---
GNOME version: 2.23/2.24


Attachments
small diff (826 bytes, patch)
2008-02-26 20:49 UTC, paul
none Details | Review

Description paul 2008-02-26 20:47:58 UTC
as the {gnome-sudoku,glchess}.in files are now generated by configure and if one builds as builddir!=srcdir, the build stops
Comment 1 paul 2008-02-26 20:49:50 UTC
Created attachment 106025 [details] [review]
small diff
Comment 2 Andreas Røsdal 2008-03-01 18:04:32 UTC
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.

http://svn.gnome.org/viewvc/gnome-games?view=revision&revision=7436
Comment 3 Thomas Andersen 2008-03-08 01:39:04 UTC
I am unable to run make with this patch. Is it just me?
Comment 4 Robert Ancell 2008-03-10 03:11:43 UTC
Doesn't build for me either...
Comment 5 Robert Ancell 2008-03-10 04:11:44 UTC
The error I get is:
make[2]: *** No rule to make target `/glchess.in', needed by `glchess'.  Stop.

Which is from src/Makefile:
glchess.in: $(top_builddir)/config.status $(srcdir)/glchess.in.in

Comment 6 Robert Ancell 2008-03-10 04:22:19 UTC
The problem is builddir is not specified on my system which is why $(builddir)/glchess.in expands to '/glchess.in'.
Comment 7 paul 2008-03-10 05:05:44 UTC
i think this is an automake issue
i'm using 1.10.1 and it works fine
this might be limited to 1.9 and lower
Comment 8 Robert Ancell 2008-03-10 12:40:17 UTC
Current configure seems to require automake >= 1.9:
AM_INIT_AUTOMAKE([1.9 no-dist-gzip dist-bzip2 foreign])
(but I don't grok the autotools...)

Does anyone know a way to fix this for 1.9 and 1.10?
Comment 9 paul 2008-03-10 21:20:36 UTC
instead of

glchess: $(builddir)/glchess.in

it could be

glchess: $(top_builddir)/glchess/src/glchess.in
Comment 10 Jason Clinton 2008-03-10 22:46:05 UTC
Fixed in SVN revision 7502. I heart automake. Thanks to all for thoughts on how to attack this. I don't think anyone really, truely understand how automake actually works ;).
Comment 11 paul 2008-03-11 08:54:36 UTC
i feel dumb

builddir always expands to .
so $(builddir)/glchess.in is just ./glchess.in
and by default, without some directory referenced, it's expected to be the current working directory

so $(top_builddir)/glchess/src doesn't even need to be there
it can just be

glchess: glchess.in

i overcomplicated things
Comment 12 Robert Ancell 2008-04-10 04:01:53 UTC
Unovercomplicated things :)
http://svn.gnome.org/viewvc/gnome-games?view=revision&revision=7611