After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 518710 - Use GChecksum for computing MD5 checksums
Use GChecksum for computing MD5 checksums
Status: RESOLVED FIXED
Product: evolution-data-server
Classification: Platform
Component: Mailer
2.22.x (obsolete)
Other Linux
: Normal enhancement
: ---
Assigned To: evolution-mail-maintainers
Evolution QA team
Depends on: 510855
Blocks:
 
 
Reported: 2008-02-25 21:37 UTC by Matthew Barnes
Modified: 2008-03-27 17:08 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Proposed patch (32.94 KB, patch)
2008-02-25 21:39 UTC, Matthew Barnes
none Details | Review
Version of this patch for camel-lite (30.32 KB, patch)
2008-02-26 10:43 UTC, Philip Van Hoof
none Details | Review
Revised patch (32.72 KB, patch)
2008-02-28 02:17 UTC, Matthew Barnes
committed Details | Review

Description Matthew Barnes 2008-02-25 21:37:48 UTC
GLib 2.16 introduces a checksum API that includes support for MD5.  We should deprecate our own MD5 API in libdataserver/md5-utils.[ch] in favor of GLib's MD5 API, as we did for Base64.

Note that GLib's checksum API is still unstable, so this patch should *not* be committed to trunk until after GLib 2.16 is included in a stable GNOME release (presumably 2.22).

I'm also blocking this bug until bug #510855 is resolved.
Comment 1 Matthew Barnes 2008-02-25 21:39:02 UTC
Created attachment 105935 [details] [review]
Proposed patch
Comment 2 Philip Van Hoof 2008-02-26 10:43:09 UTC
Created attachment 105967 [details] [review]
Version of this patch for camel-lite

Note that GCheckSum is a glib 2.16 feature and that a lot of distributions are not yet shipping this version of glib.
Comment 3 Matthew Barnes 2008-02-28 02:17:09 UTC
Created attachment 106127 [details] [review]
Revised patch

Some minor revisions now that bug #510855 is resolved.
Comment 4 Matthew Barnes 2008-03-11 01:01:53 UTC
Bumping version to a stable release.
Comment 5 Srinivasa Ragavan 2008-03-27 05:19:44 UTC
Matt, I haven't tested it, but looks OK. Commit to trunk. I assume GNOME 2.24 is gonna have glib 2.16.
Comment 6 Matthew Barnes 2008-03-27 17:08:02 UTC
GNOME 2.22 already has GLib 2.16.

I bumped the GLib requirement in configure.in before committing.  That part wasn't in the patch.

Committed to trunk (revision 8594).