GNOME Bugzilla – Bug 518710
Use GChecksum for computing MD5 checksums
Last modified: 2008-03-27 17:08:02 UTC
GLib 2.16 introduces a checksum API that includes support for MD5. We should deprecate our own MD5 API in libdataserver/md5-utils.[ch] in favor of GLib's MD5 API, as we did for Base64. Note that GLib's checksum API is still unstable, so this patch should *not* be committed to trunk until after GLib 2.16 is included in a stable GNOME release (presumably 2.22). I'm also blocking this bug until bug #510855 is resolved.
Created attachment 105935 [details] [review] Proposed patch
Created attachment 105967 [details] [review] Version of this patch for camel-lite Note that GCheckSum is a glib 2.16 feature and that a lot of distributions are not yet shipping this version of glib.
Created attachment 106127 [details] [review] Revised patch Some minor revisions now that bug #510855 is resolved.
Bumping version to a stable release.
Matt, I haven't tested it, but looks OK. Commit to trunk. I assume GNOME 2.24 is gonna have glib 2.16.
GNOME 2.22 already has GLib 2.16. I bumped the GLib requirement in configure.in before committing. That part wasn't in the patch. Committed to trunk (revision 8594).