After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 518538 - Resize grip still present when window is maximized
Resize grip still present when window is maximized
Status: RESOLVED FIXED
Product: xchat-gnome
Classification: Other
Component: general
0.18
Other Linux
: Normal minor
: ---
Assigned To: xchat-gnome maintainers
xchat-gnome maintainers
Depends on:
Blocks:
 
 
Reported: 2008-02-25 04:43 UTC by Diego Escalante Urrelo (not reading bugmail)
Modified: 2008-09-03 23:15 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
[PATCH] Hide resize grip when window is maximized (1.96 KB, patch)
2008-08-31 23:44 UTC, Juan Percy Rojas Cruz
none Details | Review
[PATCH] Hide resize grip when window is maximized (1.95 KB, patch)
2008-09-03 22:54 UTC, Juan Percy Rojas Cruz
committed Details | Review

Description Diego Escalante Urrelo (not reading bugmail) 2008-02-25 04:43:41 UTC
ssia.
Should not be there when the window is maximized, but it is.

*resize grip is the dotted corner down to the right in the window used to resize it.
Comment 1 Christian Persch 2008-08-31 18:31:17 UTC
Use the window-state-event event on the main window to show/hide the resize grip.
Comment 2 Juan Percy Rojas Cruz 2008-08-31 23:44:58 UTC
Created attachment 117737 [details] [review]
[PATCH] Hide resize grip when window is maximized

 src/fe-gnome/main-window.c |   17 +++++++++++++++++
 1 files changed, 17 insertions(+), 0 deletions(-)
Comment 3 Christian Persch 2008-09-01 11:54:14 UTC
+	if (event->changed_mask == GDK_WINDOW_STATE_MAXIMIZED)
+	{
+		if (event->new_window_state == GDK_WINDOW_STATE_MAXIMIZED)

You should not test for strict equality in these 2 places, just see if the bit is set with "&". With that fixed, ok to commit to svn trunk. Thanks for the patch!
Comment 4 Juan Percy Rojas Cruz 2008-09-03 22:54:57 UTC
Created attachment 117971 [details] [review]
[PATCH] Hide resize grip when window is maximized

 src/fe-gnome/main-window.c |   17 +++++++++++++++++
 1 files changed, 17 insertions(+), 0 deletions(-)
Comment 5 Christian Persch 2008-09-03 23:04:56 UTC
Thanks!
Comment 6 Juan Percy Rojas Cruz 2008-09-03 23:07:43 UTC
My first patch \o/
Comment 7 Diego Escalante Urrelo (not reading bugmail) 2008-09-03 23:15:30 UTC
Committed. Thanks.