After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 51823 - gettext fixes
gettext fixes
Status: VERIFIED FIXED
Product: GIMP
Classification: Other
Component: Internationalisation
1.x
Other Solaris
: Normal normal
: ---
Assigned To: GIMP Bugs
GIMP Bugs
Depends on:
Blocks:
 
 
Reported: 2001-03-07 17:35 UTC by The Written Word
Modified: 2009-08-15 18:40 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
PATCH (20.82 KB, patch)
2001-03-07 17:35 UTC, The Written Word 		none Details | Review

Description The Written Word 2001-03-07 17:35:13 UTC 
The attached patch fixes:

1. If --with-included-gettext is specified, need to
   -I$(top_srcdir)/intl
2. Fix for AM_WITH_NLS on Solaris (upgrade to latest serial #108)
Comment 1 The Written Word 2001-03-07 17:35:30 UTC 
Created attachment 374 [details] [review]
PATCH
Comment 2 Raphaël Quinet 2001-04-26 18:12:54 UTC 
Re-assigning all Gimp bugs to default component owner (Gimp bugs list)
Comment 3 Raphaël Quinet 2001-06-19 15:48:34 UTC 
I think that something similar to your "-I$(top_srcdir)/intl" patch
has already been applied to the 1.2.2 branch, but I am not sure.  I
use Solaris 2.6, but I have GNU gettext installed so I do not use
the "--with-included-gettext" option.  Someone else should test
this...
Comment 4 Sven Neumann 2001-06-30 17:35:31 UTC 
please try with gimp-1.2.2-pre2
Comment 5 The Written Word 2001-07-01 03:21:09 UTC 
I just updated from CVS and tried a build on HP-UX 11.00 which does
*not* have <libintl.h>. ENABLE_NLS is defined in config.h and I get:

gmake[3]: Entering directory
`/opt/build/gimp-1.2.2/plug-ins/dbbrowser'
cc -DHAVE_CONFIG_H -I. -I. -I../..
-I../..                             
-I/opt/TWWfsw/gtk+12/include/gtk-1.2
-I/opt/TWWfsw/glib12/include/glib-1.2
-I/opt/TWWfsw/glib12/lib/glib/include -I/usr/contrib/X11R6/include
-I/usr/include/X11R6                             
-I/opt/TWWfsw/gimp12/include
-DLOCALEDIR=\""/opt/TWWfsw/gimp12/share/locale"\"
-I/opt/TWWfsw/jpeg/include -I/opt/TWWfsw/libpng10/include
-I/opt/TWWfsw/libtiff35/include -I/opt/TWWfsw/xpm/include
-I/opt/TWWfsw/zlib11/include -DGTK_DISABLE_COMPAT_H  +O2 -Ae -z +ESlit
+Onofltacc +DAportable +Oentrysched +Odataprefetch -c dbbrowser.c
cpp: "../../libgimp/gimpintl.h", line 41: error 4036: Can't open
include file 'libintl.h'.
gmake[3]: *** [dbbrowser.o] Error 1

I looked at plug-ins/dbbrowser/Makefile.am and don't see how the
toplevel intl/ directory gets added to INCLUDES so don't see how
--with-included-gettext will work unless <libintl.h> exists on the
system (as is the case with Solaris).

I still think plug-ins/*/Makefile.am needs -I$(top_srcdir)/intl added
to INCLUDES.

Note that my gettext is 0.10.38 but I don't think this matters.
Comment 6 Sven Neumann 2001-07-02 00:57:17 UTC 
OK, we finally went ahead and added -I$(top_srcdir)/intl to all 
Makefiles. Please do test this as soon as possible and report back.

2001-07-02  Sven Neumann  <sven@gimp.org>

 * plug-ins/*/Makefile.am
 * plug-ins/common/mkgen.pl: added -I$(top_srcdir)/intl to INCLUDES.
 This will hopefully fix #51823 without breaking it for other platforms.
Comment 7 Sven Neumann 2001-07-02 23:22:50 UTC 
gimp-1.2.2-pre3 is out which should have this problem solved. Please
reopen if not.