After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 518042 - gst_pad_push() return value is ignored
gst_pad_push() return value is ignored
Status: RESOLVED INCOMPLETE
Product: GStreamer
Classification: Platform
Component: gst-omx
git master
Other Linux
: Normal normal
: git master
Assigned To: Felipe Contreras (banned)
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2008-02-22 10:55 UTC by Tommi Myöhänen
Modified: 2009-01-19 12:13 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Tommi Myöhänen 2008-02-22 10:55:48 UTC
In gstomx_base_filter.c there is a separate output_thread that calls push_buffer() that in turn calls gst_pad_push(). The return value of gst_pad_push() is not taken, and _chain() function (almost) always returns GST_FLOW_OK.

Instead, the output_thread should save this GstFlowReturn value and _chain() should use it as a return value. This way the downstream _push() return value gets propagated upstream, e.g. when pipeline is set to NULL. Currently the parser element just keeps on pushing frames to decoder, since chain incorrectly returns GST_FLOW_OK even the gst_pad_push() has returned GST_FLOW_WRONG_STATE.
Comment 1 Felipe Contreras (banned) 2008-02-22 18:10:43 UTC
I haven't tried to reproduce this but I implemented the changes as you suggested.

It's committed, please check.
Comment 2 Felipe Contreras (banned) 2008-02-28 17:34:54 UTC
I just committed a couple of changes that should improve the situation when seeking, but it's not perfect.

I also have issues when starting the playback.

Please verify.
Comment 3 Felipe Contreras (banned) 2008-02-28 17:36:48 UTC
Ignore the last comment, wrong bug report.
Comment 4 Christoph Wurm 2009-01-19 12:13:13 UTC
Closing this bug report as no further information has been provided. Please feel free to reopen this bug if you can provide the information asked for.
Thanks!