After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 517991 - problems with configure file depending on GCC compiler
problems with configure file depending on GCC compiler
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other opensolaris
: Normal normal
: 0.10.18
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2008-02-22 01:54 UTC by Brian Cameron
Modified: 2008-02-22 05:25 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch fixing problem. (802 bytes, patch)
2008-02-22 01:54 UTC, Brian Cameron 		committed Details | Review

Description Brian Cameron 2008-02-22 01:54:29 UTC 
I noticed that we were no longer installing the gstsubparse plugin in gst-plugins-base.  It turns out that the problem was caused due to tests in configure.ac failing because "-Wall -Werror" is being hardcoded to some tests.
Not sure why this is necessary for a configure script.  Anyway, these options
should only be added when using GCC since they don't work with other compilers, such as Sun Studio.

I'm attaching a patch that removes the offending -Wall and -Werror references from configure.ac.  Can this go upstream, or can the configure script be smarter about only adding these options when GCC is being used?  Thanks.
Comment 1 Brian Cameron 2008-02-22 01:54:52 UTC 
Created attachment 105739 [details] [review]
patch fixing problem.
Comment 2 Sebastian Dröge (slomo) 2008-02-22 05:25:27 UTC 
Thanks, fixed:

2008-02-22  Sebastian Dröge  <slomo@circular-chaos.org>

	Patch by: Brian Cameron <brian dot cameron at sun dot com>

	* configure.ac:
	Don't hardcode -Wall and -Werror for configure checks, this fails
	with non-GCC compilers. Fixes bug #517991.