After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 517717 - Use g_get_user_config_dir
Use g_get_user_config_dir
Status: RESOLVED FIXED
Product: totem
Classification: Core
Component: Movie player
2.21.x
Other Linux
: Normal minor
: ---
Assigned To: General Totem maintainer(s)
General Totem maintainer(s)
Depends on:
Blocks: 523057
 
 
Reported: 2008-02-20 18:13 UTC by Philip Withnall
Modified: 2008-03-25 15:09 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Use g_get_user_config_dir() (2.48 KB, patch)
2008-02-21 21:22 UTC, Philip Withnall 		committed Details | Review

Description Philip Withnall 2008-02-20 18:13:13 UTC 
We should use g_get_user_config_dir instead of hardcoding the directory in totem_dot_dir in totem-uri.c. See http://uwstopia.nl/blog/2008/02/hardcoded-configuration-path

Should we implement a fallback to check the old directory if the new one isn't found?
Comment 1 Bastien Nocera 2008-02-20 18:21:10 UTC 
It's fine just to replace it, but it's also used for the browser-plugin, so the docs would need to be updated.
Comment 2 Philip Withnall 2008-02-21 21:22:26 UTC 
Created attachment 105727 [details] [review]
Use g_get_user_config_dir()
Comment 3 Philip Withnall 2008-02-21 21:31:06 UTC 
2008-02-21  Philip Withnall  <pwithnall@svn.gnome.org>

	* browser-plugin/README.browser-plugin:
	* browser-plugin/totemPluginGlue.cpp:
	* src/backend/bacon-video-widget-xine.c: (setup_config),
	(bacon_video_widget_unrealize):
	* src/totem-uri.c: (totem_dot_dir): Change to use
	g_get_user_config_dir() instead of hardcoding the config
	directory. This breaks old configurations, which were
	in ~/.gnome2/Totem --- they're now in ~/.config/totem/, and
	use the XDG base directory spec. (Closes: #517717)
Comment 4 Christian Persch 2008-02-21 22:05:26 UTC 
(In reply to comment #3)
>         directory. This breaks old configurations, which were
>         in ~/.gnome2/Totem --- they're now in ~/.config/totem/, 

Why are existing settings not migrated ?
Comment 5 Philip Withnall 2008-02-24 18:12:39 UTC 
I believe it's because we basically only stored geometry settings there, which are no great loss. Bastien?
Comment 6 Bastien Nocera 2008-02-24 18:14:31 UTC 
I don't see a big need to do it, as long as it's documented.