After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 517285 - Glossy filter: fails with pattern; useless option
Glossy filter: fails with pattern; useless option
Status: RESOLVED FIXED
Product: GIMP
Classification: Other
Component: Script-Fu
git master
Other All
: Normal minor
: 2.4
Assigned To: GIMP Bugs
GIMP Bugs
: 519672 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2008-02-18 19:17 UTC by Ulf-D. Ehlert
Modified: 2008-03-01 14:34 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Bugfix (3.78 KB, patch)
2008-02-18 19:18 UTC, Ulf-D. Ehlert 		needs-work Details | Review
Corrected bugfix (1.03 KB, patch)
2008-02-19 11:27 UTC, Ulf-D. Ehlert 		committed Details | Review

Description Ulf-D. Ehlert 2008-02-18 19:17:39 UTC 
1) The Glossy filter fails when a pattern is used instead of gradient
   blend: "unbound variable: old-patterns":

   The variable "old-patterns" is used to (re)set the active pattern,
   but is never defined or initialized. It looks like someone forgot
   to remove some code lines when he/she added "gimp-context-push" and
   "gimp-context-pop".

2) There is an option "Default bumpmap setting", but it doesn't have
   any effect. The corresponding parameter "noninteractive" is never
   used. Obviously another memory leak...
Comment 1 Ulf-D. Ehlert 2008-02-18 19:18:32 UTC 
Created attachment 105529 [details] [review]
Bugfix
Comment 2 Sven Neumann 2008-02-18 20:06:07 UTC 
Removing the parameter breaks compatibility. Please submit a patch that only fixes the first problem.
Comment 3 Ulf-D. Ehlert 2008-02-19 11:27:30 UTC 
Created attachment 105574 [details] [review]
Corrected bugfix

Sorry, you are right!
Comment 4 Sven Neumann 2008-02-19 12:54:43 UTC 
I have applied this to both branches:

2008-02-19  Sven Neumann  <sven@gimp.org>

	* plug-ins/script-fu/scripts/glossy.scm: applied patch from
	Ulf-D. Ehlert that fixes a bug in the Glossy script when used with
	a pattern instead of a gradient blend (bug #517285).

I also changed the script to actually use the "Default Bumpmap Settings" parameter. This change only went into trunk:

2008-02-19  Sven Neumann  <sven@gimp.org>

	* plug-ins/script-fu/scripts/glossy.scm: actually use the "Default
	Bumpmap Settings" parameter. Problem spotted by Ulf-D. Ehlert.
Comment 5 Raphael 2008-03-01 14:34:07 UTC 
*** Bug 519672 has been marked as a duplicate of this bug. ***