After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 517259 - Escape hostname for use in gconf key
Escape hostname for use in gconf key
Status: RESOLVED FIXED
Product: gnome-settings-daemon
Classification: Core
Component: plugins
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gnome-settings-daemon-maint
gnome-settings-daemon-maint
Depends on:
Blocks:
 
 
Reported: 2008-02-18 16:47 UTC by Vincent Untz
Modified: 2008-02-19 22:15 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Escape hostname for gconf (needs testing) (1.28 KB, patch)
2008-02-18 16:47 UTC, Vincent Untz
committed Details | Review

Description Vincent Untz 2008-02-18 16:47:21 UTC
Novell bug: https://bugzilla.novell.com/show_bug.cgi?id=345925

===
Running FACTORY version of GNOME, if you press the caps lock key, I get a
dialog box that comes up saying:
  "An error occurred while loading or saving configuration information for
gnome-settings-daemon. Some of your configuration settings may not work
properly."

The details of the error box says:
  "Bad key or directory name:
"/desktop/gnome/peripherals/keyboard/host-3(NXDOMAIN)/0/numlock_on": `(' is an
invalid character in key/directory names"

For some reason I have my hostname set to "3(NXDOMAIN)" due to some other
networking errors and using a hotel wireless network.  It is not the same
hostname that was when gnome started up.

I'm guessing that we need to "sanitize" the hostname variable to be something
that gconf would allow as a key/directory name.
===

I'll attach a patch. I couldn't test it since my compilation chain is broken right now.
Comment 1 Vincent Untz 2008-02-18 16:47:53 UTC
Created attachment 105517 [details] [review]
Escape hostname for gconf (needs testing)
Comment 2 Jens Granseuer 2008-02-19 19:59:52 UTC
Looks good, please commit.
Comment 3 Vincent Untz 2008-02-19 22:15:24 UTC
Committed.