After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 517223 - Encoded version of file name shown
Encoded version of file name shown
Status: RESOLVED FIXED
Product: f-spot
Classification: Other
Component: Browsing
0.4.x
Other All
: Normal minor
: ---
Assigned To: Ruben Vermeersch
F-spot maintainers
Depends on:
Blocks:
 
 
Reported: 2008-02-18 13:56 UTC by Alexander Skwar
Modified: 2008-06-04 17:31 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Unescape the string (478 bytes, patch)
2008-02-18 21:26 UTC, Robert Paskowitz
none Details | Review
Unescape in TimeDialog (443 bytes, patch)
2008-02-19 20:03 UTC, Robert Paskowitz
none Details | Review

Description Alexander Skwar 2008-02-18 13:56:24 UTC
I've got a file named like this:

/home/askwar/Desktop/My Pictures/Photos/Kategorien/Ausflüge/Insel Mainau/[2008-02-10--12.34.05] (cimg4982) Alexander mit Cédric auf Schoß 6, Insel Mainau, {2.6 MB}.jpg

When I open/select this file, the following is shown on the starting terminal:

open uri = file:///home/askwar/Desktop/My Pictures/Photos/Kategorien/Ausflüge/Insel Mainau/[2008-02-10--12.34.05] (cimg4982) Alexander mit Cédric auf Schoß 6, Insel Mainau, {2.6 MB}.jpg

That's fine.

BUT in the lower left hand side of the f-spot window, the following is displayed:

%5B2008-02-10--12.34.05%5D%2...nau,%20%7B2.6%20MB%7D.jpg

Copying that file name from there with the mouse results in:
%5B2008-02-10--12.34.05%5D%20(cimg4982)%20Alexander%20mit%20C%C3%A9dric%20auf%20Scho%C3%9F%206,%20Insel%20Mainau,%20%7B2.6%20MB%7D.jpg

That's in the "box" where the version can be selected and the date is shown.

I do not want to see such a cryptic version of the filename there. I might be wrong, but I actually think, that in previous versions, the "correct" (ie. unencoded) vesion of the filename was shown there.

Other information:
Using f-spot 0.4.1 on Gentoo Linux.
Comment 1 Robert Paskowitz 2008-02-18 21:26:26 UTC
Created attachment 105543 [details] [review]
Unescape the string

This patch, against F-Spot 0.4.2 modifies InfoBox.cs to call System.Uri.UnescapeDataString() on the filename so that it is displayed properly.
Comment 2 Alexander Skwar 2008-02-19 11:30:49 UTC
Your patch is working well!
Comment 3 Maxxer 2008-02-19 19:52:21 UTC
the same bug is present in the date adjust dialog also. ;)
Comment 4 Robert Paskowitz 2008-02-19 20:03:24 UTC
Created attachment 105600 [details] [review]
Unescape in TimeDialog

This patch does the same, but for TimeDialog.cs.
Comment 5 Stephane Delcroix 2008-02-20 16:50:03 UTC
fixed in r3705
Comment 6 Ruben Vermeersch 2008-05-24 18:07:00 UTC
I'm going to reopen this bug, as regressions related to this one might appear soon. Once the new sidebar lands, we'll have to revisit this bug.
Comment 7 Ruben Vermeersch 2008-06-04 17:31:55 UTC
Should be an issue, as the old code is used.