After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 516938 - Add user_data parameter to GstTagList GstTagMergeFunc
Add user_data parameter to GstTagList GstTagMergeFunc
Status: RESOLVED NOTABUG
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
git master
Other Linux
: Normal enhancement
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2008-02-17 03:00 UTC by José Alburquerque
Modified: 2008-02-22 20:48 UTC
See Also:
GNOME target: ---
GNOME version: 2.19/2.20

Attachments
GstTagMergeFunc user data parameter addition (1.83 KB, patch)
2008-02-17 03:02 UTC, José Alburquerque 		rejected Details | Review

Description José Alburquerque 2008-02-17 03:00:17 UTC 
Is it possible to include this patch to allow the GstTagMergeFunc function pointer type of GstTagList to accept user data (as a gpointer)?  It would be useful for gstreamermm which needs this to pass in what is called a "Slot" which would then be used to then call a user defined C++ "callback".  Thanks very much.
Comment 1 José Alburquerque 2008-02-17 03:02:09 UTC 
Created attachment 105412 [details] [review]
GstTagMergeFunc user data parameter addition
Comment 2 Jan Schmidt 2008-02-17 12:23:00 UTC 
No - absolutely not. At least, not in this form. We can't break API by changing public functions like that.

Any change like this has to be done through compatible API addition, and the old functions have to continue working.
Comment 3 José Alburquerque 2008-02-18 01:00:18 UTC 
I understand.  I think I'm missing something logically.  If need be, I may submit a patch that does just what you say it should.  Thanks.
Comment 4 José Alburquerque 2008-02-22 20:48:50 UTC 
Yes I was missing something logically.  New wrapper API (such as the C++ gstreamermm wrapper API) will most likely not need to register new taglists (which is mainly done directly with gstreamer C API).  After surveying the docs, I now realize that the merge function is used to merge taglist values into one and is provided (the merge function that is) when registering new taglists (which again will most likely be done only in gstreamer).  Right now, I see no reason why new taglists will be registered using C++ wrapper API (gstreamermm) so I don't think I'll be providing a patch for this at this moment.  Thanks.