After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 516160 - gstrtpbin did not ignore streams with no SR when doing association
gstrtpbin did not ignore streams with no SR when doing association
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal blocker
: 0.10.6
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2008-02-13 02:06 UTC by Olivier Crête
Modified: 2008-02-14 16:25 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
patch to ignore streams that haven't received a SR packet (1001 bytes, patch)
2008-02-13 02:07 UTC, Olivier Crête
committed Details | Review

Description Olivier Crête 2008-02-13 02:06:37 UTC
gstrtpbin did not ignore streams that had no received a SR packet yet for association/synchronisation, so it would produce an impossibly high ts-offset for them, I'm attaching a patch that ignores them until they receive a SR/SDES packet.
Comment 1 Olivier Crête 2008-02-13 02:07:23 UTC
Created attachment 105113 [details] [review]
patch to ignore streams that haven't received a SR packet
Comment 2 Olivier Crête 2008-02-14 08:21:58 UTC
Think we can push that into gst-p-bad 0.10.6, without this patch, gstrtpbin won't work unless caps are force on the network recv side (and hence is unusable with something like farsight).
Comment 3 Wim Taymans 2008-02-14 15:49:27 UTC
Well, I marked it as a blocker although it is not technically a regression. The patch is simple and correct, though.
Comment 4 Jan Schmidt 2008-02-14 16:18:32 UTC
I'm still trying to nail down a patch policy for the freeze, but it'll be along the lines of 'simple, tested bug fixes & fixes for regressions', which will cover something like this....
Comment 5 Wim Taymans 2008-02-14 16:25:58 UTC
        Patch by: Olivier Crete <tester@tester.ca>

        * gst/rtpmanager/gstrtpbin.c: (gst_rtp_bin_associate):
        Ignore streams that did not receive an SR packet when doing
        synchronisation. Fixes #516160.