GNOME Bugzilla – Bug 516007
Use standard::description file attribute as window title if availible
Last modified: 2008-04-27 01:06:39 UTC
standard::description was recently added to gio for uses such as window title. It has the name plus optional extra info like "foo on $host" or "bar (in trash)".
Created attachment 109930 [details] [review] 516007-use-standard_description-gio-attribute-when-available.patch
Created attachment 109937 [details] [review] uses nautilus-file machinery more. Here's the patch I futilely attempted to send to the list.
Paweł, A.: Thanks for working on this! Marking attachment 109930 [details] [review] by Paweł as "rejected", and patch 109937 by A. as "reviewed". Paweł: A. is right, synchronous I/O should not be used. A.: The patch looks fine. I wonder why you changed NAUTILUS_FILE_DEFAULT_ATTRIBUTES, and appended ",mountable::*", though. It is already in the list, and is not related to the file description, since the description is in the "standard" namespace.
I didn't add it, I removed it; mountable::* was there twice, I reduced it to one: - "standard::*,access::*,mountable::*,time::*,unix::*,owner::*,selinux::*,thumbnail::*,mountable::*" + "standard::*,access::*,mountable::*,time::*,unix::*,owner::*,selinux::*,thumbnail::*" Seemed redundant to me ;) Good to commit?
Yes. Sorry for the noise.
2008-04-26 A. Walton <awalton@gnome.org> reviewed by: Christian Neumair * libnautilus-private/nautilus-file-private.h: * libnautilus-private/nautilus-file-utilities.c (nautilus_compute_title_for_location): * libnautilus-private/nautilus-file.c (update_info_internal), (nautilus_file_get_description): * libnautilus-private/nautilus-file.h: Use standard::description in the window title when it's available. Closes bug #516007. Committed, closing.