After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 515980 - [directdraw] Does not chain up finalize functions properly
[directdraw] Does not chain up finalize functions properly
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other Linux
: Normal blocker
: 0.10.7
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2008-02-12 11:10 UTC by Sebastian Dröge (slomo)
Modified: 2008-02-12 12:24 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
ddraw.diff (2.10 KB, patch)
2008-02-12 11:10 UTC, Sebastian Dröge (slomo) 		committed Details | Review

Description Sebastian Dröge (slomo) 2008-02-12 11:10:17 UTC 
Hi,
the directdrawsink does not chain up the finalize functions properly, resulting in possible memory leaks.
Comment 1 Sebastian Dröge (slomo) 2008-02-12 11:10:39 UTC 
Created attachment 105029 [details] [review]
ddraw.diff
Comment 2 Jan Schmidt 2008-02-12 12:13:09 UTC 
Hopefully Sebastien will confirm this for us, but pop it in.
Comment 3 Sebastian Dröge (slomo) 2008-02-12 12:23:06 UTC 
2008-02-12  Sebastian Dröge  <slomo@circular-chaos.org>

	* sys/directdraw/gstdirectdrawsink.c:
	(gst_ddrawsurface_class_init), (gst_ddrawsurface_finalize),
	(gst_directdraw_sink_finalize):
	Properly chain up finalize functions. Fixes bug #515980.