GNOME Bugzilla – Bug 515907
[Patch] RGBA Enabled System Monitor
Last modified: 2012-12-30 22:20:40 UTC
I have created a patch which enables transparent themeing of gnome-system-monitor, basically adds some nice eyecnady! Please see the screen shot at http://idnzor.net/tmp/rgba_gnome-system-monitor.png This makes use of the new transparency capabilities of the Murrine GTK+ theme engine, you can read more about these changes here: http://www.cimitan.com/blog/2007/12/12/gtk-rgba-transparent-widgets-with-the-murrine-engine The patch for this can be found here: http://idnzor.net/tmp/rgba_gnome-system-monitor.patch This is all 100% degradable - so users without a composite window manager will see no difference, it is also super fast still! The latest murrine engine has not been released yet which will allow this effect, although it is for the most part stable. As you can see this is only a small patch.... Look forward to your feedback Jon
Created attachment 105003 [details] [review] Initial patch
Looks ok, but why this isn't done inside GTK ?
Since is not mature enough for *every* situation. For example totem will crash because of the player, but simple applications like system-monitor will be 100% stable.
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.
Reopening since colormap should always be available: FROM: if (colormap && gdk_screen_is_composited (screen)) { gtk_widget_set_default_colormap(colormap); } TO: if (colormap) { gtk_widget_set_default_colormap(colormap); }
Created attachment 105109 [details] [review] Updated patch Always use RGBA colormap where available. In fact the previous patch fails in that situation: 1) Start system-monitor with a non-composited window manager (e.g. metacity without compositing extension) 2) Start compiz or a composited window manager What's wrong? the application will be opaque and need to be restarted... ugly :)
of course updated against svn 2302
I have committed my patch, sorry for bypassing your approval, but there's no reason why we should check if the screen is composited :) CLOSING again
No problem.
Is this not a rather strange feature to add to a single application in the whole desktop? It makes the system monitor look broken WRT everything else.
RGBA doesn't make system monitor look different
Andrea: I'm running Ubuntu Intrepid with the "NewHuman" theme and system monitor is the only application which is doing translucent backgrounds. Perhaps this issue is actually in the theme, but the system monitor is the only thing showing it, so I assumed it was because it sets an RGBA colormap.
It is a bug of the theme, not of this patch.
*** Bug 553957 has been marked as a duplicate of this bug. ***
I don't use compiz, i'm going to watch you argue :)
I've already asked ubuntu maintainers to fix their themes. They will do.
sadly setting an RGBA color-map makes a number of (what used to be fast) operations around scrolling the settings extremely slow on a lot of older hardware that doesn't have accelerated XRender. Is there really a reason why we don't want to check for a composited desktop before doing this odd thing ?
We should remove that patch, though it is useful to show bugs in drivers: check out older nvidia card, if you scroll the window it appears totally messed up.
I'm unclear on the status of this one: It seems to me that the decision of whether or not a particular widget or gtk region should be transparent should be up to the engine and/or the theme. It would be very interesting to have all gtk applications have this transparency effect...
Thanks for taking the time to report this bug. However, you are using a version that is too old and not supported anymore. GNOME developers are no longer working on that version, so unfortunately there will not be any bug fixes for the version that you use. By upgrading to a newer version of GNOME you could receive bug fixes and new functionality. You may need to upgrade your Linux distribution to obtain a newer version of GNOME. Please feel free to reopen this bug if the problem still occurs with a newer version of GNOME.