After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 515860 - plugins should not install headers - fix metadata
plugins should not install headers - fix metadata
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal blocker
: 0.10.6
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2008-02-11 20:14 UTC by Jan Schmidt
Modified: 2008-02-12 23:14 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
simple patch to disable installing the header (1011 bytes, patch)
2008-02-11 22:04 UTC, Jan Schmidt 		none Details | Review

Description Jan Schmidt 2008-02-11 20:14:00 UTC 
Plugins are not allowed to install headers - we don't add API that way.

The tags in the 'metadata/metadatatags.h' header should be merged into libgsttag in -base after this release and used from there.

In the meantime, the header should not be installed at all.
Comment 1 Tim-Philipp Müller 2008-02-11 20:46:56 UTC 
> In the meantime, the header should not be installed at all.

Agreed.


One thing to consider: some of the tags may change their GType when the move to -base. This might cause problems later on when building + using the released -bad against CVS -base, e.g. when the enum types are actually turned into enum types instead of G_TYPE_UINT.
Comment 2 Jan Schmidt 2008-02-11 22:00:00 UTC 
Hmmm. Do you have a solution for mitigating that, or do you think it's ok because metadata is in -bad?
Comment 3 Jan Schmidt 2008-02-11 22:04:26 UTC 
Created attachment 104992 [details] [review]
simple patch to disable installing the header
Comment 4 Jan Schmidt 2008-02-12 23:14:02 UTC 
committed:

2008-02-12  Jan Schmidt  <jan.schmidt@sun.com>

        * ext/metadata/Makefile.am:
        Don't install a header file. We will have to merge these
        tags into libgsttag after the release and use them from there.
        Fixes: #515860