After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 515809 - change licence of totem-subtitle-encoding.c to LGPL
change licence of totem-subtitle-encoding.c to LGPL
Status: RESOLVED FIXED
Product: totem
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: General Totem maintainer(s)
General Totem maintainer(s)
Depends on: 518264
Blocks:
 
 
Reported: 2008-02-11 16:38 UTC by Guillaume Desmottes
Modified: 2013-05-29 09:51 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
switch to LGPL (1.03 KB, patch)
2008-02-11 16:38 UTC, Guillaume Desmottes
none Details | Review
updated, forgot on GPL reference (1.20 KB, patch)
2008-02-11 19:05 UTC, Guillaume Desmottes
none Details | Review
updated patch + COPYING (1.63 KB, patch)
2008-04-28 12:33 UTC, Guillaume Desmottes
needs-work Details | Review
mail approving the relicensing (3.30 KB, text/plain)
2008-04-28 12:35 UTC, Guillaume Desmottes
  Details
use proper header (2.17 KB, patch)
2008-05-09 15:13 UTC, Guillaume Desmottes
committed Details | Review

Description Guillaume Desmottes 2008-02-11 16:38:11 UTC
According to our discussion by mail and with the approval of its author, totem-subtitle-encoding.c have to be relicensed under LGPL.
Comment 1 Guillaume Desmottes 2008-02-11 16:38:57 UTC
Created attachment 104954 [details] [review]
switch to LGPL
Comment 2 Guillaume Desmottes 2008-02-11 19:05:28 UTC
Created attachment 104978 [details] [review]
updated, forgot on GPL reference
Comment 3 Bastien Nocera 2008-04-24 15:32:37 UTC
Could you please update the patch? Could also please attach your e-mail discussion with the author to this bug, and mention the licensing in the top-level COPYING file?
Comment 4 Guillaume Desmottes 2008-04-28 12:33:47 UTC
Created attachment 110034 [details] [review]
updated patch + COPYING
Comment 5 Guillaume Desmottes 2008-04-28 12:35:59 UTC
Created attachment 110035 [details]
mail approving the relicensing
Comment 6 Bastien Nocera 2008-04-28 15:26:57 UTC
Please use the proper heading for the LGPL. LGPL v2 is outdated:
http://www.gnu.org/licenses/old-licenses/lgpl-2.1.html#SEC4
Comment 7 Guillaume Desmottes 2008-05-09 15:13:12 UTC
Created attachment 110646 [details] [review]
use proper header
Comment 8 Guillaume Desmottes 2008-05-11 12:00:10 UTC
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.
Comment 9 Christian Persch 2008-05-30 17:51:59 UTC
That file seems to have been copied largely from gnome-terminal's src/encoding.c which is GPL, so just the permission of the person(s) who took it and changed it for totem isn't sufficient.

Luckily for you, the file in g-t used to have LGPL header (see bug 464410), so it's probably ok to use it under LGPL. Adding the gstreamer exception clause that's now in totem svn probably is not ok though.
Comment 10 Bastien Nocera 2008-05-31 12:37:18 UTC
Agreed, more work for you Guillaume. The list of committers is in:
http://svn.gnome.org/viewvc/gnome-terminal/trunk/src/encoding.c?view=log

Cheers
Comment 11 Guillaume Desmottes 2008-07-08 15:25:17 UTC
I sent a email asking them about relicensing.
Comment 12 Christophe Fergeau 2008-07-08 15:34:28 UTC
My contribution to that file was trivial 
http://svn.gnome.org/viewvc/gnome-terminal/trunk/src/encoding.c?r1=669&r2=673
so you probably don't need my consent to relicense, but I'm ok with it anyway ;)
Comment 13 Kjartan Maraas 2008-07-08 17:22:38 UTC
I'm with Christophe here. Ok by me if my work counts enough to worry about.
Comment 14 Behdad Esfahbod 2008-07-20 08:04:27 UTC
Red Hat is ok with the relicensing.
Comment 15 Bastien Nocera 2009-11-06 17:07:18 UTC
This was sorted, the file is now marked as LGPL as the original files were, and the license exception were removed.
Comment 16 Patrick Welche 2013-05-29 09:47:57 UTC
If asked the question: "Under which license is totem distributed?" Is the
answer still "GPL v2 + exceptions"?
Comment 17 Bastien Nocera 2013-05-29 09:51:49 UTC
(In reply to comment #16)
> If asked the question: "Under which license is totem distributed?" Is the
> answer still "GPL v2 + exceptions"?

Yes.