After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 515725 - [xingmux] Fails on big endian systems
[xingmux] Fails on big endian systems
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-ugly
git master
Other Linux
: Normal blocker
: 0.10.7
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2008-02-11 10:05 UTC by Sebastian Dröge (slomo)
Modified: 2008-02-11 13:29 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
xingmux.diff (1.14 KB, patch)
2008-02-11 11:00 UTC, Sebastian Dröge (slomo) 		reviewed Details | Review
xingmux.diff (1.18 KB, patch)
2008-02-11 11:11 UTC, Sebastian Dröge (slomo) 		committed Details | Review

Description Sebastian Dröge (slomo) 2008-02-11 10:05:32 UTC 
Hi,
the xingmux unit test currently fails on big endian systems:

elements/xingmux.c:125:F:general:test_xing_remux:0: Assertion 'memcmp (test_xing, GST_BUFFER_DATA (outbuffer), GST_BUFFER_SIZE (outbuffer)) == 0' failed

I'm debugging this now...
Comment 1 Sebastian Dröge (slomo) 2008-02-11 11:00:37 UTC 
Created attachment 104913 [details] [review]
xingmux.diff

ok, found the cause with the help of Sjoerd Simons (who tested all this on PPC and found the silly bug).

It's not a good idea to use GUINT32_FROM_BE on gint64 :)
Comment 2 Tim-Philipp Müller 2008-02-11 11:06:39 UTC 
I'd use G_MAXUINT32 and "%" G_GINT64_FORMAT instead of "%lld".
Comment 3 Sebastian Dröge (slomo) 2008-02-11 11:10:09 UTC 
Ok, changed both locally and will commit that changed version when Jan accepts it.
Comment 4 Sebastian Dröge (slomo) 2008-02-11 11:11:41 UTC 
Created attachment 104914 [details] [review]
xingmux.diff
Comment 5 Sebastian Dröge (slomo) 2008-02-11 13:29:00 UTC 
2008-02-11  Sebastian Dröge  <slomo@circular-chaos.org>

        * gst/mpegaudioparse/gstxingmux.c: (generate_xing_header):
        Correctly write the size in bytes on big endian systems.
        Fixes bug #515725.