After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 515721 - [rfb] rfbsrc leaking the rfb decoder
[rfb] rfbsrc leaking the rfb decoder
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal blocker
: 0.10.6
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2008-02-11 09:37 UTC by Sebastian Dröge (slomo)
Modified: 2008-02-12 05:18 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
rfb.diff (680 bytes, patch)
2008-02-11 09:40 UTC, Sebastian Dröge (slomo) 		committed Details | Review

Description Sebastian Dröge (slomo) 2008-02-11 09:37:32 UTC 
Hi,
the rfbsrc is currently leaking it's rfb decoder. The instance struct of it is never freed. This showed up while running the states unit test in valgrind.
Comment 1 Sebastian Dröge (slomo) 2008-02-11 09:40:32 UTC 
Created attachment 104904 [details] [review]
rfb.diff
Comment 2 Sebastian Dröge (slomo) 2008-02-11 09:41:37 UTC 
For some reason there's another leak.

The states unit test leaks the complete element although the element's dispose() function is called...
Comment 3 Jan Schmidt 2008-02-11 21:36:06 UTC 
Is there a librfb deb package? I don't seem to have it available.
Comment 4 David Schleef 2008-02-11 22:11:38 UTC 
librfb should have been slurped into -bad long ago.  It's in my personal CVS somewhere.

http://www.comedi.org/cgi-bin/viewvc.cgi/librfb/
Comment 5 David Schleef 2008-02-11 22:21:46 UTC 
Erm, actually, it appears I did that long ago.  Perhaps why it's in gst/, not ext/.
Comment 6 Jan Schmidt 2008-02-11 22:38:34 UTC 
Oh hey, look at that. Whoops :)
Comment 7 Jan Schmidt 2008-02-12 00:16:26 UTC 
OK, with the patch applied, I don't see any rfbsrc leak.

That management of the rfb_decoder is a bit funky - it's allocated in _init, but freed in an error condition in _start(). That can be fixed after release though.
Comment 8 Sebastian Dröge (slomo) 2008-02-12 05:18:35 UTC 
2008-02-12  Sebastian Dröge  <slomo@circular-chaos.org>

	* gst/librfb/gstrfbsrc.c: (gst_rfb_src_dispose):
	Free the rfb decoder on finalize. Fixes bug #515721.