After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 515708 - [dvdsubparse] Leaks a pad template
[dvdsubparse] Leaks a pad template
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-ugly
git master
Other Linux
: Normal blocker
: 0.10.7
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2008-02-11 08:22 UTC by Sebastian Dröge (slomo)
Modified: 2008-02-11 13:30 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
dvdsub.diff (836 bytes, patch)
2008-02-11 08:23 UTC, Sebastian Dröge (slomo) 		committed Details | Review

Description Sebastian Dröge (slomo) 2008-02-11 08:22:37 UTC 
Hi,
dvdsubparse currently leaks a pad template. gst_static_pad_template_get() creates a new pad template that needs to be unref'ed after use.

Instead of the dubious gst_pad_template_get_caps (gst_static_pad_template_get()) one should probably use gst_static_pad_template_get_caps().

Patch is attached.
Comment 1 Sebastian Dröge (slomo) 2008-02-11 08:23:37 UTC 
Created attachment 104900 [details] [review]
dvdsub.diff
Comment 2 Sebastian Dröge (slomo) 2008-02-11 13:30:37 UTC 
2008-02-11  Sebastian Dröge  <slomo@circular-chaos.org>

	* gst/dvdsub/gstdvdsubparse.c: (gst_dvd_sub_parse_init):
	Stop leaking src pad templates. Fixes bug #515708.