After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 515654 - xvimagesink doesn't build with --disable-xshm
xvimagesink doesn't build with --disable-xshm
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
0.10.17
Other Mac OS
: Normal normal
: 0.10.18
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2008-02-10 23:28 UTC by Branko Čibej
Modified: 2008-02-11 06:47 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fix 0.10.17 base plugins compile on Mac OS X (477 bytes, patch)
2008-02-10 23:31 UTC, Branko Čibej 		committed Details | Review

Description Branko Čibej 2008-02-10 23:28:07 UTC 
The function

sys/xvimage/xvimagesink.c:gst_xvimagesink_handle_xerror

is defined inside an "#ifdef HAVE_XSHM" block, but used outside it (at line 549 in gst_xvimagesink_xvimage_new in the same file). The attached patch is a wild guess but allows the build to finish.
Comment 1 Branko Čibej 2008-02-10 23:31:45 UTC 
Created attachment 104880 [details] [review]
Fix 0.10.17 base plugins compile on Mac OS X
Comment 2 Sebastian Dröge (slomo) 2008-02-11 06:47:30 UTC 
Thanks, committed:

2008-02-11  Sebastian Dröge  <slomo@circular-chaos.org>

	Patch by: Branko Čibej <brane at xbc dot nu>

	* sys/xvimage/xvimagesink.c:
	Fix build of xvimagesink if we don't have XShm, e.g. on Mac OS X.
	Fixes bug #515654.