After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 515621 - draw editor buttons without relief
draw editor buttons without relief
Status: RESOLVED FIXED
Product: GIMP
Classification: Other
Component: User Interface
git master
Other All
: Normal enhancement
: ---
Assigned To: GIMP Bugs
GIMP Bugs
Depends on:
Blocks:
 
 
Reported: 2008-02-10 19:41 UTC by weskaggs
Modified: 2008-02-10 20:53 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
screenshot showing several docks with altered buttons (219.97 KB, image/png)
2008-02-10 19:43 UTC, weskaggs 		  Details
patch for app/widgets/gimpeditor.c (619 bytes, patch)
2008-02-10 19:45 UTC, weskaggs 		committed Details | Review

Description weskaggs 2008-02-10 19:41:57 UTC 
I think the interface looks considerably nicer if the buttons that appear at the bottom of several editor widgets are drawn without relief.  I am going to raise this topic on the developer's list -- I am filing this enhancement request in order to have a place to attach a screenshot and an (almost trivial) patch that does it.
Comment 1 weskaggs 2008-02-10 19:43:52 UTC 
Created attachment 104863 [details]
screenshot showing several docks with altered buttons
Comment 2 weskaggs 2008-02-10 19:45:46 UTC 
Created attachment 104864 [details] [review]
patch for app/widgets/gimpeditor.c
Comment 3 Michael Natterer 2008-02-10 20:25:52 UTC 
That indeed makes them look more like toolbars which is imho a nice
removal of clutter. I like that change. What does the UI team think?
Comment 4 Michael Natterer 2008-02-10 20:33:12 UTC 
Nah, just go ahead and commit this change please :)
Comment 5 weskaggs 2008-02-10 20:41:31 UTC 
Done.  But I won't quite resolve the bug report yet.

2008-02-10  Bill Skaggs  <weskaggs@primate.ucdavis.edu>

	* app/widgets/gimpeditor.c: draw editor buttons without
	relief, see bug #515621.
Comment 6 Michael Natterer 2008-02-10 20:53:53 UTC 
Turned into a style property. Closing as FIXED.

2008-02-10  Michael Natterer  <mitch@gimp.org>

	* app/widgets/gimpeditor.c: add button-relief style property which
	defaults to NONE.