After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 515362 - gnome-appearance-properties crashed with SIGSEGV in __mktime_internal()
gnome-appearance-properties crashed with SIGSEGV in __mktime_internal()
Status: RESOLVED FIXED
Product: gnome-desktop
Classification: Core
Component: libgnome-desktop
2.21.x
Other Linux
: Normal normal
: ---
Assigned To: Desktop Maintainers
Desktop Maintainers
Depends on:
Blocks:
 
 
Reported: 2008-02-09 09:17 UTC by Sebastien Bacher
Modified: 2008-02-11 22:42 UTC
See Also:
GNOME target: ---
GNOME version: 2.21/2.22


Attachments
Fix the crash (533 bytes, patch)
2008-02-09 13:15 UTC, Vincent Untz
committed Details | Review

Description Sebastien Bacher 2008-02-09 09:17:01 UTC
The bug has been opened on https://bugs.launchpad.net/ubuntu/+source/gnome-control-center/+bug/189191

"Binary package hint: gnome-control-center

At some point when I started up gnome-appearance-properties it failed to open. It briefly shows the window with several thumbnails of themes, except one for the custom theme. then it segfaults (after <1sec). after installing the debugging librar
ies for gnome I found that the error resides in __mktime_internal during a create_thumbnail call in libgnome-desktop-2. see attached strace and gdb output.

output:
roel@eliezer:~$ gnome-appearance-properties

(gnome-appearance-properties:9024): appearance-properties-WARNING **: Unknown Tag: comment

(gnome-appearance-properties:9024): appearance-properties-WARNING **: Unknown Tag: comment

Segmentation fault (core dumped)

  • #0 __mktime_internal
    from /lib/libc.so.6
  • #1 get_as_slideshow
    at gnome-bg.c line 1751
  • #2 gnome_bg_create_thumbnail
    at gnome-bg.c line 1157
  • #3 gnome_wp_item_get_thumbnail
    at gnome-wp-item.c line 183
  • #4 wp_props_load_wallpaper
    at appearance-desktop.c line 169
  • #5 IA__g_hash_table_foreach
    at /build/buildd/glib2.0-2.15.4/glib/ghash.c line 1067
  • #6 wp_load_stuffs
    at appearance-desktop.c line 885
  • #7 IA__g_main_context_dispatch
    at /build/buildd/glib2.0-2.15.4/glib/gmain.c line 2064
  • #8 g_main_context_iterate
    at /build/buildd/glib2.0-2.15.4/glib/gmain.c line 2697
  • #9 IA__g_main_loop_run
    at /build/buildd/glib2.0-2.15.4/glib/gmain.c line 2905
  • #10 IA__gtk_main
    at /build/buildd/gtk+2.0-2.12.7/gtk/gtkmain.c line 1163
  • #11 main
    at appearance-main.c line 191

Comment 1 Sebastien Bacher 2008-02-09 13:08:17 UTC
new submitter comment:

"I solved my problem! It seemed that after some update the pictures in
the package gnome-backgrounds-extra-debian were all of zero length. The
segmentation fault was caused by this. I solved the problem by removing
the gnome-backgrounds-extra-debian package. Everything works perfectly
again."
Comment 2 Vincent Untz 2008-02-09 13:15:35 UTC
Created attachment 104779 [details] [review]
Fix the crash
Comment 3 Vincent Untz 2008-02-09 13:16:50 UTC
Soeren: can you give a quick look at the patch? I'm wondering if it's okay to return NULL from the function. I think it is, but I don't know the whole code...
Comment 4 Vincent Untz 2008-02-11 18:30:27 UTC
I've committed the patch since I want it in for the next release...
Comment 5 Soren Sandmann Pedersen 2008-02-11 22:42:00 UTC
Looks good to me.