After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 515237 - [avidemux] index optimization
[avidemux] index optimization
Status: RESOLVED OBSOLETE
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other Linux
: Normal enhancement
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2008-02-08 17:19 UTC by Alessandro Decina
Modified: 2009-11-16 20:04 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch (1.41 KB, patch)
2008-02-08 17:20 UTC, Alessandro Decina 		needs-work Details | Review

Description Alessandro Decina 2008-02-08 17:19:47 UTC 
I'm profiling avidemux and sorting the index seems to take a considerable amount of time. The patch sorts the index only if it's actually unsorted.
Comment 1 Alessandro Decina 2008-02-08 17:20:22 UTC 
Created attachment 104727 [details] [review]
Patch
Comment 2 Stefan Sauer (gstreamer, gtkdoc dev) 2008-02-08 17:25:09 UTC 
looks, good. I'll give it a try, but lets apply this after the freeze.
Comment 3 Stefan Sauer (gstreamer, gtkdoc dev) 2008-03-16 14:27:00 UTC 
The idea behind the patch is good, but unfortunately it only check for out-of-order when doing the index massaging. And this only happens for streams with one block only and the block being audio.
Should probably also be done for gst_avi_demux_stream_scan()
Comment 4 Edward Hervey 2009-01-30 06:49:14 UTC 
What about using GstIndex for proper index support ? And therefore not have to care about the implementation of storage/ordering/etc.
Comment 5 Stefan Sauer (gstreamer, gtkdoc dev) 2009-01-31 18:08:54 UTC 
Do we have any demuxer that uses GstIndex. For me its far from obvious how to use GstIndex.
Comment 6 Sebastian Dröge (slomo) 2009-01-31 20:03:56 UTC 
GstIndex will need much more memory though as it's very very generic :) But by using balanced binary trees it's quite fast.

Stefan, flvdemux uses GstIndex (but probably wrong, it should maybe use one writer ID per output stream).
Comment 7 Mark Nauwelaerts 2009-11-13 16:47:10 UTC 
Is this not pretty much handled by the recent avidemux index handling rewrite?
Comment 8 Stefan Sauer (gstreamer, gtkdoc dev) 2009-11-16 20:04:16 UTC 
Yep, not needed anymore. No more sort there even :)