After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 515152 - Fail to build without verbose mode
Fail to build without verbose mode
Status: RESOLVED FIXED
Product: metacity
Classification: Other
Component: general
trunk
Other Linux
: Normal normal
: ---
Assigned To: Metacity maintainers list
Metacity maintainers list
Depends on:
Blocks:
 
 
Reported: 2008-02-08 06:47 UTC by Jim Huang
Modified: 2008-02-15 04:39 UTC
See Also:
GNOME target: ---
GNOME version: 2.21/2.22


Attachments
Fixlet to verbose-mode-disabled build error (1.96 KB, patch)
2008-02-08 06:48 UTC, Jim Huang
committed Details | Review

Description Jim Huang 2008-02-08 06:47:05 UTC
In SVN trunk, it fails to build metacity without verbose mode.
Comment 1 Jim Huang 2008-02-08 06:48:49 UTC
Created attachment 104689 [details] [review]
Fixlet to verbose-mode-disabled build error

This patch hopefully fixes compilation errors when verbose mode is disabled.
Comment 2 Thomas Thurman 2008-02-10 20:06:33 UTC
I have done

make distclean
./autogen.sh --disable-verbose
make

on metacity trunk and seen no errors. Can you show us the errors you're getting?
Comment 3 Jim Huang 2008-02-11 01:49:01 UTC
@tthurman

The option to disable verbose mode is --disable-verbose-mode, and the corresponding compilation errors are as following:
...
core/util.c: In function 'meta_set_verbose':
core/util.c:137: warning: implicit declaration of function 'ensure_logfile'
core/util.c:137: warning: nested extern declaration of 'ensure_logfile'
core/util.c: In function 'meta_bug':
core/util.c:376: error: 'logfile' undeclared (first use in this function)
core/util.c:376: error: (Each undeclared identifier is reported only once
core/util.c:376: error: for each function it appears in.)
core/util.c: In function 'meta_warning':
core/util.c:405: error: 'logfile' undeclared (first use in this function)
core/util.c: In function 'meta_fatal':
core/util.c:429: error: 'logfile' undeclared (first use in this function)
make[4]: *** [libmetacity_private_la-util.lo] Error 1
make[4]: Leaving directory `/tmp/metacity/src'
Comment 4 Thomas Thurman 2008-02-13 03:59:40 UTC
Huh, weird. The help says that the option is --disable-verbose. I'll fix that first.
Comment 5 Thomas Thurman 2008-02-13 19:44:38 UTC
Okay, that's fixed. I apologise for taking so long to fix this, but I'd assumed that something that went in during the last few weeks caused the problem. This must have been around for years, though, and it goes to show that nobody uses this option!

Patch seems fine and does what it's supposed to. If you want to commit it, go ahead, otherwise I'll deal with it tonight.