GNOME Bugzilla – Bug 515152
Fail to build without verbose mode
Last modified: 2008-02-15 04:39:44 UTC
In SVN trunk, it fails to build metacity without verbose mode.
Created attachment 104689 [details] [review] Fixlet to verbose-mode-disabled build error This patch hopefully fixes compilation errors when verbose mode is disabled.
I have done make distclean ./autogen.sh --disable-verbose make on metacity trunk and seen no errors. Can you show us the errors you're getting?
@tthurman The option to disable verbose mode is --disable-verbose-mode, and the corresponding compilation errors are as following: ... core/util.c: In function 'meta_set_verbose': core/util.c:137: warning: implicit declaration of function 'ensure_logfile' core/util.c:137: warning: nested extern declaration of 'ensure_logfile' core/util.c: In function 'meta_bug': core/util.c:376: error: 'logfile' undeclared (first use in this function) core/util.c:376: error: (Each undeclared identifier is reported only once core/util.c:376: error: for each function it appears in.) core/util.c: In function 'meta_warning': core/util.c:405: error: 'logfile' undeclared (first use in this function) core/util.c: In function 'meta_fatal': core/util.c:429: error: 'logfile' undeclared (first use in this function) make[4]: *** [libmetacity_private_la-util.lo] Error 1 make[4]: Leaving directory `/tmp/metacity/src'
Huh, weird. The help says that the option is --disable-verbose. I'll fix that first.
Okay, that's fixed. I apologise for taking so long to fix this, but I'd assumed that something that went in during the last few weeks caused the problem. This must have been around for years, though, and it goes to show that nobody uses this option! Patch seems fine and does what it's supposed to. If you want to commit it, go ahead, otherwise I'll deal with it tonight.