After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 515119 - untranslatable strings
untranslatable strings
Status: RESOLVED FIXED
Product: gnome-keyring
Classification: Core
Component: general
2.21.x
Other Linux
: Normal major
: ---
Assigned To: GNOME keyring maintainer(s)
GNOME keyring maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2008-02-08 01:16 UTC by André Klapper
Modified: 2008-02-15 13:58 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Patch proposition (4.05 KB, patch)
2008-02-11 18:58 UTC, Claude Paroz
rejected Details | Review

Description André Klapper 2008-02-08 01:16:54 UTC
the following strings need translator comments, because "it"/%s is unclearly and can have several translations depending on the gender of the noun.
http://live.gnome.org/TranslationProject/DevGuidelines/Use_comments

#: ../pk/gkr-pk-object-storage.c:174
#, fuzzy, c-format
msgid "An application wants access to the %s '%s', but it is locked"

#: ../pk/gkr-pk-object-storage.c:177
#, fuzzy, c-format
msgid "An application wants access to '%s', but it is locked"

#: ../pk/gkr-pk-object-storage.c:182
#, fuzzy, c-format
msgid "The system wants to import the %s '%s', but it is locked."

#: ../pk/gkr-pk-object-storage.c:185
#, fuzzy, c-format
msgid "The system wants to import '%s', but it is locked."

#: ../pk/gkr-pk-object-storage.c:197
#, fuzzy, c-format
msgid "Automatically unlock this %s when I log in."
Comment 1 André Klapper 2008-02-08 01:24:15 UTC
from pk/gkr-pk-object-storage.c:

/*
 * TRANSLATORS:
 * display_type will be the type of the object like 'certificate' or 'key'
 * details will the name of the object to unlock.
 */

that is totally useless. translator comments MUST immediately preceed a message, see http://live.gnome.org/TranslationProject/DevGuidelines/Use%20comments .

display_type = gkr_pkix_parsed_type_to_display (type);
title = g_strdup_printf (_("Unlock %s"), display_type);
primary = g_strdup_printf (_("Enter password for the %s to unlock"), display_type);


from /pkix/gkr-pkix-parser.c:

const gchar*
gkr_pkix_parsed_type_to_display (GQuark type)
{
	if (type == GKR_PKIX_PRIVATE_KEY)
		return _("private key");
	else if (type == GKR_PKIX_CERTIFICATE)
		return _("certificate");
	else if (type == GKR_PKIX_PUBLIC_KEY)
		return _("public key");


this will never work in *any* other language.
"unlock %s" requires %s to be accusative, but "private key" without any context looks like nominative.
please NEVER SPLIT SENTENCES LIKE THIS:
http://live.gnome.org/TranslationProject/DevGuidelines/Never%20split%20sentences


string freeze is on monday.
Comment 2 Stef Walter 2008-02-10 17:53:32 UTC
Fixed the translator comments.

In the second case currently we retrieve the user presentable description of the object, and include it in the sentence. Many more object types will be added in the future. If that is wrong then I have no idea what to do. 

Patches welcome.
Comment 3 André Klapper 2008-02-10 18:31:20 UTC
in many languages "private key" has a different grammatical gender than certificate.
the "the" in the sentence "Enter password for the %s to unlock" depends on this grammatical gender.
e.g. in german "for THE private key" becomes "für DEN privaten Schlüssel" while "for THE certificate" becomes "für DAS Zertifikat".

you may want to bring this up to the gnome-i18n@ mailing list and ask for ideas, but to me it looks like you will need a seperate string for each case, also for the many more object types to come.
Comment 4 Stef Walter 2008-02-10 23:04:25 UTC
I wonder what we would do if those type strings were to come from external non-code files, which was an option. Hrm, I worder what nautilus does when it needs to build messages with things like "JPEG Image" or "Folder" or "Plain text file".
Comment 5 Claude Paroz 2008-02-11 18:58:52 UTC
Created attachment 104977 [details] [review]
Patch proposition

Here is a patch who could partially resolve the problem.
Comment 6 Stef Walter 2008-02-14 23:37:07 UTC
That patch makes various strings more difficult for the user. ie: What is an 'object'? 

I've committed a fix which should fix this, at the expense of code maintainability. 
Comment 7 André Klapper 2008-02-15 09:57:08 UTC
i'm sorry for the expense of code maintainability, but i prefer having GNOME software that can be translated to other languages than english-only... :-/
Comment 8 Stef Walter 2008-02-15 13:58:39 UTC
Certainly. My point was that I would prefer to have code maintainability take a hit, rather than the user (by providing generic strings).