After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 514964 - [dc1394] port to new stable 2.0.x API
[dc1394] port to new stable 2.0.x API
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal enhancement
: 0.10.7
Assigned To: GStreamer Maintainers
GStreamer Maintainers
: 517899 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2008-02-07 12:48 UTC by Tim-Philipp Müller
Modified: 2008-02-26 05:51 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
update to libdc1394-2.0.x stable API (6.94 KB, patch)
2008-02-25 16:24 UTC, daniel fischer
committed Details | Review

Description Tim-Philipp Müller 2008-02-07 12:48:23 UTC
dc1394 currently uses API which was changed or removed before the final 2.0.0 version. Shouldn't be much work, but probably best done by someone who has hardware to test it:

This is what you get when compiling against 2.0.1:

gstdc1394.c: In function 'gst_dc1394_change_state':
gstdc1394.c:471: warning: implicit declaration of function 'dc1394_free_camera'
gstdc1394.c: In function 'gst_dc1394_get_cam_caps':
gstdc1394.c:851: warning: implicit declaration of function 'dc1394_find_cameras'
gstdc1394.c:854: error: 'DC1394_NO_CAMERA' undeclared (first use in this function)
gstdc1394.c:854: error: (Each undeclared identifier is reported only once
gstdc1394.c:854: error: for each function it appears in.)
gstdc1394.c: In function 'gst_dc1394_open_cam_with_best_caps':
gstdc1394.c:1124: warning: implicit declaration of function 'dc1394_cleanup_iso_channels_and_bandwidth'
Comment 1 Sebastian Dröge (slomo) 2008-02-21 16:07:39 UTC
*** Bug 517899 has been marked as a duplicate of this bug. ***
Comment 2 daniel fischer 2008-02-25 11:36:00 UTC
Just a note that i am working on this. About to get my IIDC cam delivered today to test. Initial port (to get it to compile) was trivial, but i'll obviously wait for being able to test this with actual hardware..
Comment 3 daniel fischer 2008-02-25 16:24:04 UTC
Created attachment 105918 [details] [review]
update to libdc1394-2.0.x stable API

restore basic function of dc1394src, tested with a (single) PointGrey Firefly MV:

require pkgconfig for libdc1394 >= 2.0.0;
add dc1394_t library initialization struct (initialized on STATE_CHANGE_NULL_TO_READY, deinited on opposite);
update to new camera enumeration api (and a few more api changes); fix some gst_structure_empty_new("").

expect further (feature-enhancement) patches in new bug reports as i explore the features of my new camera :)
Comment 4 Sebastian Dröge (slomo) 2008-02-26 05:51:22 UTC
2008-02-26  Sebastian Dröge  <slomo@circular-chaos.org>

	Patch by: Daniel Fischer <dan at f3c dot com>

	* configure.ac:
	* ext/dc1394/gstdc1394.c: (gst_dc1394_change_state),
	(gst_dc1394_get_cam_caps), (gst_dc1394_open_cam_with_best_caps):
	* ext/dc1394/gstdc1394.h:
	Add support for libdc1394 2.0.0 and above and require this version
	now. Fixes bug #514964.