After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 514948 - [souphttpsrc] configurable buffer size setting and zero-copy
[souphttpsrc] configurable buffer size setting and zero-copy
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other All
: Normal enhancement
: 0.10.7
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2008-02-07 10:53 UTC by Wouter Cloetens
Modified: 2008-02-22 07:18 UTC
See Also:
GNOME target: ---
GNOME version: Unversioned Enhancement

Attachments
configurable buffer size setting and zero-copy (6.17 KB, patch)
2008-02-07 20:55 UTC, Wouter Cloetens 		none Details | Review
configurable buffer size setting and zero-copy (10.01 KB, patch)
2008-02-12 15:11 UTC, Wouter Cloetens 		committed Details | Review

Description Wouter Cloetens 2008-02-07 10:53:43 UTC 
See bug 513810.
libsoup-2.4 2.3.2 is scheduled for release on Monday 11 February. By then, I will add a libsoup patch to this bug.
Comment 1 Wouter Cloetens 2008-02-07 20:55:54 UTC 
Created attachment 104669 [details] [review]
configurable buffer size setting and zero-copy

Implement "blocksize" property and zero-copy.
Comment 2 Wouter Cloetens 2008-02-12 15:11:47 UTC 
Created attachment 105059 [details] [review]
configurable buffer size setting and zero-copy

Implement "blocksize" property and zero-copy.
Prefix proxy URIs with "http://" if they do not start with that.
Catch errors early in connection status, such as hostname resolution issues or proxy failures; fixes hang in that situation.
Comment 3 Sebastian Dröge (slomo) 2008-02-22 07:18:45 UTC 
Ok, committed this one finally :)

Works good although I don't think it makes much of a difference for a HTTP source.

2008-02-22  Sebastian Dröge  <slomo@circular-chaos.org>

	Patch by: Wouter Cloetens <wouter at mind dot be>

	* configure.ac:
	* ext/soup/gstsouphttpsrc.c: (gst_soup_http_src_cancel_message),
	(gst_soup_http_src_finished_cb), (gst_soup_http_src_chunk_free),
	(gst_soup_http_src_chunk_allocator),
	(gst_soup_http_src_got_chunk_cb), (gst_soup_http_src_create),
	(gst_soup_http_src_start), (gst_soup_http_src_set_proxy):
	* ext/soup/gstsouphttpsrc.h:
	Implement zero-copy and make the buffer size configurable.
	Fixes bug #514948.