GNOME Bugzilla – Bug 514619
A button on gnome-power-manager prefs is not translatable
Last modified: 2008-08-05 06:35:01 UTC
Please describe the problem: There's a button on the gnome-power-manager prefs window that is not translatable. The button is "Reset to defaults". Steps to reproduce: 1. 2. 3. Actual results: Expected results: Does this happen every time? Other information:
Created attachment 104510 [details] [review] This patch should resolve the issue Simple patch to add as translatable the missing button.
Please apply to 2-20 and trunk please. Thanks.
Hmm... sorry.. should I do that?
Yey Milo, do you have an SVN account? Richard already said the patch is ok, so feel free to commit :). If you don't have an SVN account, then please let us know so Richard, I, or any other guy with an account can do it for you. Thanks for you help! (note: updating patch status)
(In reply to comment #4) > Yey Milo, do you have an SVN account? Richard already said the patch is ok, so > feel free to commit :). > If you don't have an SVN account, then please let us know so Richard, I, or any > other guy with an account can do it for you. Sorry, I don't have an SVN account... please commit it for me. > Thanks for you help! Thank you!
Uhm, no longer valid for trunk? Richard?
Running an rgrep on trunk: ted@shi:~/Development/gnome-power-manager/trunk$ rgrep efaults * | grep eset src/gpm-phone.c: /* reset to defaults until we get BatteryStateChanged */ ted@shi:~/Development/gnome-power-manager/trunk$ I don't think it's valid any longer. I'm marking it as "fixed", which is probably a bit presumptuous of me, but that way it'll drop off the list of patches needing review unless someone disagrees with my decision.
Rejected and obsolete are more precise. And yes, I agree, no longer valid.