After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 514590 - brightness applet is bloaty
brightness applet is bloaty
Status: RESOLVED FIXED
Product: gnome-power-manager
Classification: Deprecated
Component: applets
2.21.x
Other Linux
: Normal normal
: ---
Assigned To: GNOME Power Manager Maintainer(s)
GNOME Power Manager Maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2008-02-05 18:32 UTC by Bill Nottingham
Modified: 2008-02-19 11:46 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
the fix (560 bytes, patch)
2008-02-18 16:49 UTC, Matthias Clasen 		none Details | Review

Description Bill Nottingham 2008-02-05 18:32:36 UTC 
res-base Wins  GCs Fnts Pxms Misc   Pxm mem  Other   Total   PID Identifier    
2a00000    10  495    0  467   37     1017K     12K   1029K  3887 gnome-brightness-applet

It's using roughly five times the X memory of the panel. 4 times the X memory of metacity. And more GCs and pixmaps than anything except firefox.

Something must be wrong here.

gnome-power-manager-2.21.1-2.fc9.x86_64
Comment 1 Bill Nottingham 2008-02-05 18:35:15 UTC 
This appears to be because it leaks references like mad; this can be seen pretty easily by running xrestop and opening/closing the slider.
Comment 2 Matthias Clasen 2008-02-18 16:49:03 UTC 
Created attachment 105518 [details] [review]
the fix
Comment 3 Richard Hughes 2008-02-18 17:40:54 UTC 
Good man. Please can you commit to trunk. Thanks.
Comment 4 Richard Hughes 2008-02-19 11:46:20 UTC 
2008-02-19  Richard Hughes  <richard@hughsie.com>

	* applets/brightness/brightness-applet.c: (gpm_applet_draw_cb):
	The brightness applet leaks memory, and appears to be because it leaks
	references like mad; this can be seen pretty easily by running xrestop
	and opening/closing the slider.
	Free the gc to avoid the leak, fixes #514590 (Matthias Clasen)