After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 514394 - Show and Hide buttons are unnecessary duplication of checkbox functionality
Show and Hide buttons are unnecessary duplication of checkbox functionality
Status: RESOLVED FIXED
Product: nautilus
Classification: Core
Component: Preferences
2.21.x
Other All
: Normal minor
: ---
Assigned To: Nautilus Maintainers
Nautilus Maintainers
Depends on:
Blocks:
 
 
Reported: 2008-02-04 19:57 UTC by Marcin Gałązka
Modified: 2008-04-06 22:28 UTC
See Also:
GNOME target: ---
GNOME version: 2.21/2.22

Attachments
Proposed patch (3.09 KB, patch)
2008-02-04 19:58 UTC, Marcin Gałązka 		committed Details | Review

Description Marcin Gałązka 2008-02-04 19:57:02 UTC 
User can switch a visibility of a colum (see List Columns tab) using a checkbox located next to the column name - both buttons are redundant here.

Other information:
Comment 1 Marcin Gałązka 2008-02-04 19:58:54 UTC 
Created attachment 104424 [details] [review]
Proposed patch

Proposed patch removes both buttons and their signals methods.
Comment 2 Cosimo Cecchi 2008-02-25 22:17:05 UTC 
I agree with this, confirming.

Please subscribe to the nautilus mailing list [1] and submit there your patches
for review, thanks.

[1] nautilus-list@gnome.org - you can subscribe from
http://mail.gnome.org/mailman/listinfo/nautilus-list
Comment 3 Baptiste Mille-Mathias 2008-04-05 19:17:21 UTC 
Marcin,

did you act as Cosimo said ?
Comment 4 Marcin Gałązka 2008-04-06 20:13:02 UTC 
Yep, see http://mail.gnome.org/archives/nautilus-list/2008-March/msg00079.html. You should be able to apply cleanly the patch to the trunk.
Comment 5 Christian Neumair 2008-04-06 22:28:03 UTC 
Thanks for your efforts. I just committed the patch to trunk:

http://svn.gnome.org/viewvc/nautilus?view=revision&revision=14044

Closing.