GNOME Bugzilla – Bug 514384
Use GIO instead of gnome_help_*
Last modified: 2008-08-18 11:03:08 UTC
This would also require bumping the GLib version, but it can't hurt to file the bug now. http://live.gnome.org/GnomeGoals/RemoveGnomeOpenGnomeHelp
Created attachment 107358 [details] [review] Patch, shamely ripped from http://live.gnome.org/GnomeGoals/RemoveGnomeOpenGnomeHelp
Couldn't you keep the existing totem_action_error call instead of putting in a load of error dialogue code?
Created attachment 108233 [details] [review] New version Hello, I've updated the patch keeping totem_action_error Regards
Created attachment 111514 [details] [review] Remove the libgnome call to open the help (updated) Now that bug #514396 has landed, we can use that to open the help. It does require GTK+ 2.13.0, though. The patch also removes a bit of stubbornly-remaining GnomeVFS configure.in cruft.
GTK+ 2.12 is still the one planned for the next version of GNOME. Unless that changes, we can't commit this patch...
http://live.gnome.org/TwoPointTwentythree/Platform Actually, I think they're currently going with GTK+ 2.14, although vuntz is worried it'll be a bit late. As it's not definite, though, I'd agree with you.
hi there, can't this patch be commited? I think gtk+ 2.14 is targeted for 2.24. Regards
+ g_get_current_time (¤t_time); + + if (gtk_show_uri (gtk_widget_get_screen (totem->win), "ghelp:totem", + current_time.tv_sec * 1000 + current_time.tv_usec, This is wrong. Just use gtk_get_current_event_time() for the timestamp.
Created attachment 116834 [details] [review] Remove the libgnome call to open the help (updated again) Guess I didn't look thoroughly enough for the appropriate timestamp function.
You're missing not hiding the menu item when a GTK+-only build is done.
2008-08-18 Bastien Nocera <hadess@hadess.net> * configure.in: update GTK+ req * src/totem-audio-preview.c: remove unneeded gnome include * src/totem-menu.c (totem_ui_manager_setup): * src/totem.c (totem_action_show_help): Use a newer GTK+ to launch the help, and don't require libgnomeui for that, based on patch from Philip Withnall <philip@tecnocode.co.uk> (Closes: #514384)