After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 514384 - Use GIO instead of gnome_help_*
Use GIO instead of gnome_help_*
Status: RESOLVED FIXED
Product: totem
Classification: Core
Component: Movie player
2.21.x
Other Linux
: Normal normal
: ---
Assigned To: General Totem maintainer(s)
General Totem maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2008-02-04 19:04 UTC by Philip Withnall
Modified: 2008-08-18 11:03 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Patch, shamely ripped from http://live.gnome.org/GnomeGoals/RemoveGnomeOpenGnomeHelp (1.48 KB, patch)
2008-03-15 21:26 UTC, Baptiste Mille-Mathias
none Details | Review
New version (1.52 KB, patch)
2008-03-29 18:00 UTC, Baptiste Mille-Mathias
none Details | Review
Remove the libgnome call to open the help (updated) (1.18 KB, patch)
2008-05-25 17:34 UTC, Philip Withnall
none Details | Review
Remove the libgnome call to open the help (updated again) (1.06 KB, patch)
2008-08-17 22:26 UTC, Philip Withnall
none Details | Review

Description Philip Withnall 2008-02-04 19:04:10 UTC
This would also require bumping the GLib version, but it can't hurt to file the bug now.

http://live.gnome.org/GnomeGoals/RemoveGnomeOpenGnomeHelp
Comment 1 Baptiste Mille-Mathias 2008-03-15 21:26:19 UTC
Created attachment 107358 [details] [review]
Patch, shamely ripped from http://live.gnome.org/GnomeGoals/RemoveGnomeOpenGnomeHelp
Comment 2 Philip Withnall 2008-03-16 00:17:06 UTC
Couldn't you keep the existing totem_action_error call instead of putting in a load of error dialogue code?
Comment 3 Baptiste Mille-Mathias 2008-03-29 18:00:42 UTC
Created attachment 108233 [details] [review]
New version

Hello,

I've updated the patch keeping totem_action_error

Regards
Comment 4 Philip Withnall 2008-05-25 17:34:41 UTC
Created attachment 111514 [details] [review]
Remove the libgnome call to open the help (updated)

Now that bug #514396 has landed, we can use that to open the help. It does require GTK+ 2.13.0, though.

The patch also removes a bit of stubbornly-remaining GnomeVFS configure.in cruft.
Comment 5 Bastien Nocera 2008-05-26 13:13:43 UTC
GTK+ 2.12 is still the one planned for the next version of GNOME. Unless that changes, we can't commit this patch...
Comment 6 Philip Withnall 2008-05-26 13:38:20 UTC
http://live.gnome.org/TwoPointTwentythree/Platform

Actually, I think they're currently going with GTK+ 2.14, although vuntz is worried it'll be a bit late. As it's not definite, though, I'd agree with you.
Comment 7 Baptiste Mille-Mathias 2008-08-10 17:48:54 UTC
hi there,

can't this patch be commited? I think gtk+ 2.14 is targeted for 2.24.

Regards
Comment 8 Christian Persch 2008-08-16 11:52:52 UTC
+	g_get_current_time (&current_time);
+
+	if (gtk_show_uri (gtk_widget_get_screen (totem->win), "ghelp:totem",
+		      current_time.tv_sec * 1000 + current_time.tv_usec,

This is wrong. Just use gtk_get_current_event_time() for the timestamp.
Comment 9 Philip Withnall 2008-08-17 22:26:58 UTC
Created attachment 116834 [details] [review]
Remove the libgnome call to open the help (updated again)

Guess I didn't look thoroughly enough for the appropriate timestamp function.
Comment 10 Bastien Nocera 2008-08-18 10:22:50 UTC
You're missing not hiding the menu item when a GTK+-only build is done.
Comment 11 Bastien Nocera 2008-08-18 11:03:08 UTC
2008-08-18  Bastien Nocera  <hadess@hadess.net>

	* configure.in: update GTK+ req
	* src/totem-audio-preview.c: remove unneeded gnome
	include
	* src/totem-menu.c (totem_ui_manager_setup):
	* src/totem.c (totem_action_show_help): Use a newer GTK+
	to launch the help, and don't require libgnomeui for that,
	based on patch from Philip Withnall <philip@tecnocode.co.uk>
	(Closes: #514384)