After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 514305 - [0.11] badly ordered arguments for gst_buffer_copy_metadata()
[0.11] badly ordered arguments for gst_buffer_copy_metadata()
Status: RESOLVED NOTABUG
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
git master
Other Linux
: Normal enhancement
: NONE
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2008-02-04 14:25 UTC by Siavash Safi
Modified: 2008-02-05 18:20 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Siavash Safi 2008-02-04 14:25:47 UTC 
void gst_buffer_copy_metadata (GstBuffer *dest,
                               const GstBuffer *src,
                               GstBufferCopyFlags flags);

The first argument is dest which causes the _WRAP_METHOD() to fail (gmmproc). Language bindings expect the first argument to be the self(src) argument.
Comment 1 Wim Taymans 2008-02-04 14:28:24 UTC 
damn. And we can't change that now. Moving for 0.11.
Comment 2 Murray Cumming 2008-02-04 15:06:47 UTC 
You could deprecate and add a new function at the appropriate time.
Comment 3 Jan Schmidt 2008-02-04 22:22:27 UTC 
I think I'm missing something - I don't see how the second argument is somehow a 'self' reference here.

It's more like newBuffer.init_from (src, flags), where 'dest' is the self pointer, and the arguments make sense in the order they're in.
Comment 4 Wim Taymans 2008-02-05 18:03:13 UTC 
What thaytan says! It does not matter in the end.
Comment 5 Tim-Philipp Müller 2008-02-05 18:20:18 UTC 
Also, it has the same semantics as memcpy, which makes it somewhat more intuitive IMHO.