Created attachment 104368 [details] [review]
Gst::Buffer patch

Thanks. I don't think it's quite ready:

- Several enums are hand-written. Why can't _WRAP_ENUM() be used for these. In general, please add explanatory comments in the file when doing unusual things such as this.
- void Buffer::copy_metadata(Glib::RefPtr<Buffer> other_buffer, BufferCopyFlags flags):
  This should take a const RefPtr<>&. Why isn't _WRAP_METHOD() used for this?
- Several methods should be const and/or have const method overloads.

- _WRAP_ENUM() fails on those enums

- Buffer::copy_metadata(), The C API has silly argument order:
http://gstreamer.freedesktop.org/data/doc/gstreamer/head/gstreamer/html/gstreamer-GstBuffer.html#gst-buffer-copy-metadata

- I'll check all methods :)

I'll add comments and attach a new patch

> - _WRAP_ENUM() fails on those enums

Please don't make me guess how it fails.

> Buffer::copy_metadata(), The C API has silly argument order

Oh, yes. That should be filed as a bug I think - other language bindings will also assume that the first parameter is a self/this.

Created attachment 104504 [details] [review]
Gst::Buffer patch

Thanks. I will commit this and make the corrections afterwards.