After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 514139 - audio CD icon not displayed
audio CD icon not displayed
Status: RESOLVED FIXED
Product: gvfs
Classification: Core
Component: [obsolete] hal volume monitor
0.1.x
Other Linux
: Normal normal
: ---
Assigned To: gvfs-maint
gvfs-maint
Depends on:
Blocks:
 
 
Reported: 2008-02-03 18:58 UTC by Sebastien Bacher
Modified: 2008-02-25 16:54 UTC
See Also:
GNOME target: ---
GNOME version: 2.21/2.22


Description Sebastien Bacher 2008-02-03 18:58:56 UTC 
The bug has been described on https://bugs.launchpad.net/bugs/186161

"Currently I get no icons for audio CDs on the desktop. This is the same with a new user."
Comment 1 Sebastien Bacher 2008-02-15 17:02:47 UTC 
that's because of this change, http://svn.gnome.org/viewvc/gvfs/trunk/hal/ghalvolumemonitor.c?r1=1148&r2=1176, the code ignores the drives when there is a volume without filesystem corresponding or update_discs does a find_drive_by_udi (monitor, drive_udi) call and look for a corresponding drive
Comment 2 David Zeuthen (not reading bugmail) 2008-02-15 17:12:18 UTC 
This also affects blanks discs... I'm working on a fix.
Comment 3 David Zeuthen (not reading bugmail) 2008-02-15 17:25:35 UTC 
OK, the fix looks something like this

-          if (!should_volume_be_ignored (pool, volume_dev))
+          if (!should_volume_be_ignored (pool, volume_dev) ||
+              hal_device_get_property_bool (volume_dev, "volume.disc.has_audio"
) ||
+              hal_device_get_property_bool (volume_dev, "volume.disc.is_blank"))

Will include this in my next patch to Alex.

Alex, what was the rationale for should_drive_be_ignored() in the first place?
Comment 4 David Zeuthen (not reading bugmail) 2008-02-25 16:54:49 UTC 
alexl committed a patch with this fix