GNOME Bugzilla – Bug 514135
empty CD-ROM Drive doesn't do anything when clicked
Last modified: 2008-02-29 00:43:46 UTC
The bug has been described on https://bugs.launchpad.net/bugs/188256 "The Computer 'bookmark' has icons called CD-ROM Drive for CD-ROM Drives. If you click on the icon when the drive is empty nothing happens. This is confusing. It should say empty CD-ROM Drive, or have a pop up saying that there is no media. To do nothing at all seems weird. nautilus 1:2.21.90-0ubuntu1"
Confirming.
Created attachment 105262 [details] [review] patch for gvfs GVfs part of the patch, implement poll media.
Created attachment 105264 [details] [review] patch for nautilus I don't know if this is correct...this prevented showing up of dialogs if something went wrong with the mount...maybe it was just a typo.
Created attachment 105271 [details] [review] patch for gvfs v2 Better patch for gvfs, does not always poll the drive.
The nautilus patch isn't quite right We do want to report errors for != G_IO_ERROR, i think it was supposed to be if (error->domain != G_IO_ERROR || (error->code != G_IO_ERROR_CANCELLED && error->code != G_IO_ERROR_ALREADY_MOUNTED)) { i.e. report error unless its cancelled or already mounted. I'm fixing this.
The gvfs patch doesn't seem quite right either. You can't only report failures, if you don't you have to report success, or the operation will hang.
Created attachment 106081 [details] [review] patch for gvfs v3 Revamped patch...I'm sending a mail to i18n to have their opinion for this, as committing it now would break (again) string freeze for GVfs.
i18n team has approved the freeze break request.
Please commit then!
Committed, closing. 2008-02-29 Cosimo Cecchi <cosimoc@gnome.org> * daemon/gvfsbackendcomputer.c: (recompute_files), (mount_volume_from_drive), (report_no_media_error), (poll_for_media_cb), (try_mount_mountable): Implement media polling for Computer backend, handling the case when no media is in the drive. Also adds a new string. (#514135)